Skip to content

Conversation

@marcalff
Copy link
Contributor

Fixes #5622

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (c4core) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@marcalff
Copy link
Contributor Author

@bazelbuild/bcr-maintainers

Note that this is my very first PR on this repo.

I did the best I could following instructions from the doc, but will probably need guidance to add this module.

@keith Could you take a look ?

meteorcloudy
meteorcloudy previously approved these changes Aug 26, 2025
@meteorcloudy meteorcloudy enabled auto-merge (squash) August 26, 2025 12:18
@marcalff
Copy link
Contributor Author

marcalff commented Aug 26, 2025

@meteorcloudy

Thanks for the review.

@keith or anyone

I don't understand the CI build failure here:

  • every CI fails because file BUILD is missing in c4core (there is none in the c4core repo)
  • yet I provided a build.patch and referenced it in source.json.

So there should be a BUILD file after applying the BCR scripts, correct ?

Not familiar with BCR, help appreciated.

@meteorcloudy
Copy link
Member

You can reproduce locally with https://github.com/bazelbuild/bazel-central-registry/blob/main/docs/README.md#reproduce-presubmit-builds-locally

@meteorcloudy
Copy link
Member

My guess is some mismatch among source archive layout, strip_prefix and patches.

auto-merge was automatically disabled August 29, 2025 22:01

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed meteorcloudy’s stale review August 29, 2025 22:01

Require module maintainers' approval for newly pushed changes.

@marcalff marcalff changed the title Add module c4core Add module [email protected] Aug 29, 2025
@marcalff
Copy link
Contributor Author

@meteorcloudy PTAL

I found and fixed an issue with the build_targets label in presubmit.yml.

Details at:

557a82f

@meteorcloudy meteorcloudy enabled auto-merge (squash) September 2, 2025 09:17
@meteorcloudy meteorcloudy merged commit b16365b into bazelbuild:main Sep 2, 2025
25 checks passed
mirkow pushed a commit to mirkow/bazel-central-registry that referenced this pull request Sep 22, 2025
kotlaja pushed a commit to kotlaja/bazel-central-registry that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wanted: [biojppm/c4core]

3 participants