-
Notifications
You must be signed in to change notification settings - Fork 593
Add module [email protected] #5624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (c4core) have been updated in this PR. |
|
@bazelbuild/bcr-maintainers Note that this is my very first PR on this repo. I did the best I could following instructions from the doc, but will probably need guidance to add this module. @keith Could you take a look ? |
bdd0f76 to
7502ae2
Compare
|
Thanks for the review. @keith or anyone I don't understand the CI build failure here:
So there should be a Not familiar with BCR, help appreciated. |
|
My guess is some mismatch among source archive layout, strip_prefix and patches. |
Head branch was pushed to by a user without write access
Require module maintainers' approval for newly pushed changes.
296b2a7 to
557a82f
Compare
|
@meteorcloudy PTAL I found and fixed an issue with the Details at: |
Fixes #5622