Replace .bazelversion files with symlinks
#1783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces all nested `.bazelversion` files with symbolic links to the
top-level `.bazelversion` file. Removes `scripts/sync-bazelversion.sh`.
Also removes `dt_patches/compiler_sources/.bazel{rc,version}` since
they're not required by any tests.
---
I missed updating the `.bazelversion` files in bazel-contrib#1778 because I forgot to
run `scripts/sync-bazelversion.sh`. I'd added this script previously to
avoid creating symlinks that might break Windows users that don't have
symlinks enabled. At the same time, `.bazelversion` doesn't have an
`import ../.bazelversion` directive like `.bazelrc` does.
However, it seems Windows has supported symlinks for a while, and users
shouldn't have any trouble enabling them on their workstations. We also
already use them for `protobuf.patch` files throughout the nested repos.
So it's time to use symlinks for `.bazelversion` files as well, to
ensure these files don't fall out of sync again.
WojciechMazur
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces all nested
.bazelversionfiles with symbolic links to the top-level.bazelversionfile. Removesscripts/sync-bazelversion.sh.Also removes
dt_patches/compiler_sources/.bazel{rc,version}since they're not required by any tests.Motivation
I missed updating the
.bazelversionfiles in #1778 because I forgot to runscripts/sync-bazelversion.sh. I'd added this script previously to avoid creating symlinks that might break Windows users that don't have symlinks enabled. At the same time,.bazelversiondoesn't have animport ../.bazelversiondirective like.bazelrcdoes.However, it seems Windows has supported symlinks for a while, and users shouldn't have any trouble enabling them on their workstations. We also already use them for
protobuf.patchfiles throughout the nested repos. So it's time to use symlinks for.bazelversionfiles as well, to ensure these files don't fall out of sync again.