Skip to content

Conversation

@KevinBoyette
Copy link
Contributor

Description

I was grepping through and found some examples that had the same typo.

Motivation

I found a typo and wanted to help out.

Copy link
Collaborator

@liucijus liucijus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @KevinBoyette!

@KevinBoyette
Copy link
Contributor Author

Anytime! @liucijus! I'd love to help out more. For now, I'm trying to dig into these build failures.

@liucijus
Copy link
Collaborator

Anytime! @liucijus! I'd love to help out more. For now, I'm trying to dig into these build failures.

Failures must be caused by default JDK update on CI (unrelated to your changes). There's a Rules Scala issue #1521.

@KevinBoyette
Copy link
Contributor Author

Good to know that it's not these changes that are breaking the build. I see that there's discussion around --jvmopt=-Djava.security.manager=allow.

I also see Junit4 in the error message. I'm not an expert in this space, but would an upgrade to Junit5 be worth considering? I don't see that as being a trivial change from what I can find on the internet.

@KevinBoyette
Copy link
Contributor Author

Thank you for approving!

@liucijus liucijus merged commit 330081d into bazel-contrib:master Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants