Replace zipper with singlejar #1463

simuons · 2023-01-17T08:19:46Z

Remove zipper from common attributes, singlejar is already there and can generate jars with resources.

Looking at bazel source code singlejar utility is used for:

Motivation:

use precompiled binaries ie singlejar comes precompiled via remote_java_tools while zipper is built from sources (at least in remote execution)
use single tool to accomplish same goal

Remove zipper from common attributes singlejar is already there and can generate jars with resources Looking at bazel source code `singlejar` utility is used for: * [pack_sources](https://github.com/bazelbuild/bazel/blob/455454a56e961affb041a1d4a9214f7f313a05aa/src/main/java/com/google/devtools/build/lib/rules/java/JavaInfoBuildHelper.java#L198) * [resources_jar](https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/rules/java/ResourceJarActionBuilder.java#L123) Motivation: * use precompiled binaries ie singlejar comes precompiled via remote_java_tools while zipper is built from sources (at least in remote execution) * use single tool to accomplish same goal

… version instead of system default

simuons added 3 commits January 17, 2023 10:07

Remove unused function

dfd66af

Fix //test/jmh:Run__test_jmh_test_jmh_jdk11 by specifying correct jdk…

33158d2

… version instead of system default

simuons requested a review from liucijus as a code owner January 17, 2023 08:19

liucijus approved these changes Jan 20, 2023

View reviewed changes

liucijus merged commit cb950f5 into bazel-contrib:master Jan 20, 2023

simuons deleted the replace-zipper-with-singlejar branch January 23, 2023 06:26

Provide feedback