Simplify setup of scala_toolchain and its deps #1439
Conversation
| scala_library_classpath_provider = "%s_scala_library_classpath_provider" % name | ||
| scala_macro_classpath_provider = "%s_scala_macro_classpath_provider" % name | ||
|
|
||
| print("XML", scala_xml_provider) |
|
|
||
| def setup_scala_toolchain( | ||
| name, | ||
| scala_xml_deps, |
There was a problem hiding this comment.
nit: why some attribute names ends with deps and others with classpath? What's the distinction?
There was a problem hiding this comment.
classpath is what historically was used on the toolchain, other names came when dep providers were introduced. How I see it: classpath is implicit deps on the classpath, and deps is tool related deps. But this naming assumption does not even hold with the current codebase (eg. compiler is tool, but has classpath naming). Not sure what to do about it. It's a good time to improve those names at least on the macro side. Naming suggestions are more than welcome. @simuons, WDYT?
There was a problem hiding this comment.
I don't really have good suggestion. I wasn't aware of this distinction about classpath and tools. My initial thought was "all those deps go to the classpath at some point so why the distinction". The question probably is wether users should set 'internal' deps for things like //scala/support:test_reporter but this is out of scope for this PR. So I'm ok with state as it is now.
There was a problem hiding this comment.
After thinking a bit more, I'll change it to use default providers for tools deps. This should give us more room to do future refactorings. Eg. move scala_xml dep to testing toolchain.
|
@simuons I have made scala xml and parser combinators deps to be default if not specified |
liucijus
force-pushed
the
simplify-scala-toolchain-setup
branch
from
fd8d753 to
6b522fc
Compare
2 participants
Description
Added
setup_scala_toolchainmacro to simplify scala toolchain setup.Motivation
To configuration of custom scala toolchain one needs to understand implementation details like dependency provider ids, which makes it a complicated task. We can encapsulate those details under a macro.