Allow scala_benchmark_jmh to specify a runtime_jdk version #1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shane Delmore <[email protected]>
liucijus
approved these changes
Sep 21, 2022
Contributor
Author
simuons
approved these changes
Sep 26, 2022
Collaborator
simuons
left a comment
simuons
left a comment
There was a problem hiding this comment.
Thanks and sorry for the delay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include
runtime_jdkas an anattronjmh_support:benchmark_generator.scala_benchmark_jmhcan now specify a Java runtime to build itsscala_binarywith.To test whether our changes work for different specified JDKs, we include [email protected] as an
http_archive.We don't override our Bazel's (
@.bazelversion)rules_javaand instead pull in the newerrules_javaas@rules_java_extra.This allows us to use
remote_jdk8runtimes specified here.Motivation
We want to be able to use JMH benchmarking on different Java runtimes.
Co-authored-by: Shane Delmore [email protected]