Skip to content

Put -s in front of other parameters for the ScalaTest runner. #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 29, 2022
Merged

Put -s in front of other parameters for the ScalaTest runner. #1412

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9961e03
Put -s in front of other parameters for the ScalaTest runner.
srdo-humio Jul 28, 2022
62582a0
Add tests
srdo-humio Jul 29, 2022
5b3dddb
Don't run the test target automatically
srdo-humio Jul 29, 2022
c8fe137
formatting
srdo-humio Jul 29, 2022
fd28f69
comments
srdo-humio Jul 29, 2022
c552e76
Remove wrong import added by intellij
srdo-humio Jul 29, 2022
23bc243
add to test_rules_scala
srdo-humio Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/scala_test_testfilter/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ load("@io_bazel_rules_scala//scala:scala.bzl", "scala_test")
scala_test(
name = "tests",
srcs = ["A.scala", "B.scala"],
tags = ["manual"]
Copy link
Collaborator

@liucijus liucijus Jul 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this target under test_expect_failure/ instead, where it's expected to be not passing

Copy link
Contributor Author

@srdo-humio srdo-humio Jul 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Should the shell script remain where it is, or where do I put that?

Copy link
Collaborator

@liucijus liucijus Jul 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, leave it there, thanks!

Copy link
Collaborator

@liucijus liucijus Jul 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think this shell script does not get executed - you need to include it into test_rules_scala.sh

Copy link
Contributor Author

@srdo-humio srdo-humio Jul 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be done now.

)