Skip to content

Fix rules_scala JDK lookup when using --nolegacy_external_runfiles. #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Fix rules_scala JDK lookup when using --nolegacy_external_runfiles. #1397

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b510406
Fix rules_scala JDK lookup when using --nolegacy_external_runfiles.
srdo-humio May 25, 2022
d18750e
Add regression test
srdo-humio Jun 7, 2022
27a31b0
missing bazel
srdo-humio Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scala/private/rule_impls.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def java_bin(ctx):
default_runtime = ctx.attr._java_runtime[java_common.JavaRuntimeInfo],
)

java_path = str(java_runtime.java_executable_exec_path)
java_path = str(java_runtime.java_executable_runfiles_path)

if paths.is_absolute(java_path):
javabin = java_path
Expand Down