Use a public java_compile_toolchain attr instead of _java_toolchain #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chain Co-authored-by: Shane Delmore <[email protected]>
wiwa
changed the title
wisechengyi
approved these changes
May 4, 2022
Contributor
wisechengyi
left a comment
wisechengyi
left a comment
There was a problem hiding this comment.
Thanks, Shane and Win!
| scala_junit_test( | ||
| name = "CheckBytecodeMajorVersion", | ||
| srcs = ["CheckBytecodeMajorVersionTest.scala"], | ||
| suffixes = ["Test"], |
Contributor
There was a problem hiding this comment.
for my learning, is suffixes significant?
Contributor
Author
There was a problem hiding this comment.
Yes, this is necessary for scala_junit_test to discover test classes. Specifically one of prefixes or suffixes is needed.
Contributor
There was a problem hiding this comment.
oh ok thanks! not blocking, but if there's a default pattern to follow, then this declaration can be further simplified.
Contributor
Author
There was a problem hiding this comment.
there isn't a default so we must manually specify 😞
liucijus
reviewed
May 4, 2022
|
|
||
| Assert.assertTrue( | ||
| s"Expected java 8 (major version 52) but got major version $expectJava8", | ||
| majorVersionToJdkVersion(expectJava8) == 8 |
Collaborator
There was a problem hiding this comment.
nit: here and below using assertEquals is more idiomatic in junit. Eg.:
assertEquals(
"Must be Java 8 (major version 52) bytecode",
8,
majorVersionToJdkVersion(expectJava8)
)
simuons
approved these changes
May 5, 2022
liucijus
approved these changes
May 9, 2022
Collaborator
|
Thanks, @wiwa! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow per-target selection of Java compilation toolchain.
Note: This change doesn't add similar functionality to
thrift_library.Motivation
Helps with JDK migrations by allowing targets to incrementally update.
Also allows targets to opt into newer Java syntax.
Co-authored-by: Shane Delmore [email protected]