Add runtime_jdk to scala_binary #1380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shane Delmore <[email protected]>
wisechengyi
reviewed
Apr 7, 2022
|
|
||
| # Make sure scala_binary respects runtime_jdk on bazel run | ||
| scala_binary( | ||
| name = "scala_binary_jdk_11", |
Contributor
There was a problem hiding this comment.
Thanks, Win! Could you see if we can add bazel run <this target> to somewhere like this as a test? https://github.com/bazelbuild/rules_scala/blob/master/test_rules_scala.sh
possibly test/shell/test_scala_binary.sh?
Contributor
Author
There was a problem hiding this comment.
This target is added to the list of sh_tests above, so it will be run as a test.
Contributor
There was a problem hiding this comment.
oh ok. missed that. thank you!
wisechengyi
approved these changes
Apr 7, 2022
liucijus
approved these changes
Apr 7, 2022
Contributor
Author
|
@simuons is this mergeable? |
Contributor
|
No problem at all, thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Like with #1373, we enable
runtime_jdkselection onscala_binarytargets.This specifies the
javabinary to use withbazel runon a per-target level.Motivation
Similar to #1373, we want to enable gradual migration of
scala_binarytargets to be compatible with any JDK upgrades.