Create jdeps output from classpath entries #1376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: jdeps output is used by Intellij Bazel plugin to construct project model. Current implementation adds all entries as explicit source deps, does not do distinguish between implicit or unused deps.
simuons
approved these changes
Apr 5, 2022
Collaborator
simuons
left a comment
simuons
left a comment
There was a problem hiding this comment.
LGTM. Just few minor comments.
scala/private/rule_impls.bzl
Outdated
| args.add("--Manifest", manifest) | ||
| args.add("--PrintCompileTime", print_compile_time) | ||
| args.add("--ExpectJavaOutput", expect_java_output) | ||
| if jdepsPath != None: |
Collaborator
There was a problem hiding this comment.
When jdepsPath can be None? Maybe there is no need for None and null checks?
| import java.io.IOException; | ||
| import java.io.OutputStream; | ||
|
|
||
| public class JdepsWriter { |
Collaborator
There was a problem hiding this comment.
I think according whole ceremony this class should be final with private constructor. But I'm fine with the way it is now.
| } | ||
|
|
||
| try (OutputStream outputStream = new BufferedOutputStream(new FileOutputStream(jdpesPath))) { | ||
| outputStream.write(builder.build().toByteArray()); |
Collaborator
There was a problem hiding this comment.
I think builder.build().writeTo(outputStream) should me more effective as it doesn't construct intermediary byte array.
simuons
approved these changes
Apr 8, 2022
liucijus
added a commit
to liucijus/rules_scala
that referenced
this pull request
Apr 28, 2022
This reverts commit 3dd5d81.
liucijus
added a commit
to liucijus/rules_scala
that referenced
this pull request
Apr 28, 2022
Intellij needs full jars to be able to attach sources, and providing ijars with jdeps is degrading experience when someone already uses full jars
liucijus
added a commit
to liucijus/rules_scala
that referenced
this pull request
Apr 29, 2022
Intellij needs full jars to be able to attach sources, and providing ijars with jdeps is degrading experience when someone already uses full jars
liucijus
added a commit
to liucijus/rules_scala
that referenced
this pull request
Apr 29, 2022
Intellij needs full jars to be able to attach sources, and providing ijars with jdeps is degrading experience when someone already uses full jars
liucijus
added a commit
that referenced
this pull request
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
jdeps files can be used by Intellij Bazel plugin to build project model without requiring special support for Scala rules.
This implementation is very simple: treats all classpath entries as explicit deps, and is written by ScalacWorker. I decided not to put it on dependency analyzer as it requires users to have it enabled, which can be undesired performance hit. Writing actual unused deps information from the analyzer can be implemented later.
Motivation
Improving Scala support in Intellij Bazel plugin. This should help advance support for external source attachment. Though more work is required on the plugin side: