Skip to content

Conversation

@justinass-wix
Copy link
Contributor

@justinass-wix justinass-wix commented Mar 17, 2022

Description

Updated scalatest to 3.2.9.

Updated version introduces some breaking changes by removing many of deprecated names. These were used in some tests, e.g. (FlatSpec, MustMatchers).

Motivation

Current version (3.1.2) does not support Scala 3, 3.2.9 is the lowest version that does. This PR updates updates to 3.2.9 across all Scala versions for sake of consistency.

@google-cla
Copy link

google-cla bot commented Mar 17, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@justinass-wix justinass-wix marked this pull request as ready for review March 17, 2022 13:41
Copy link
Collaborator

@liucijus liucijus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @justinass-wix!

@simuons simuons merged commit 9b85aff into bazel-contrib:master Mar 17, 2022
@justinass-wix justinass-wix deleted the justinass/scalatest_v3_2_9 branch May 9, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants