Skip to content

Move ScalaTest deps to its own repository macro #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2022
Merged

Move ScalaTest deps to its own repository macro #1356

merged 2 commits into from
Feb 15, 2022

Conversation

@liucijus
Copy link
Collaborator

@liucijus liucijus commented Feb 14, 2022 •
edited
Loading

Tech debt clean up. Moving loading of ScalaTest dependencies from scala_repositories to scalatest_repositories, which was an empty call to ease such migration.

Codebases, which get broken after this change, should call scalatest_repositories() in their WORKSPACEs:

load("@io_bazel_rules_scala//testing:scalatest.bzl", "scalatest_repositories", "scalatest_toolchain")

scalatest_repositories() # Loads ScalaTest dependencies

scalatest_toolchain()

@liucijus liucijus requested a review from simuons as a code owner February 14, 2022 19:07
@simuons simuons merged commit bb67c8e into bazel-contrib:master Feb 15, 2022
@liucijus liucijus deleted the move-scalatest-deps branch February 15, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simuons simuons simuons approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liucijus @simuons