Update scalac opts in test reporter to support Scala 3 #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Scala 3 some opts have to be removed because according to the docs, they are not implemented yet.
simuons
approved these changes
Feb 11, 2022
Collaborator
simuons
left a comment
simuons
left a comment
There was a problem hiding this comment.
Idea for the future: maybe it would be nice to have this map of opts extracted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Scala 3 some opts have to be removed because according to the docs, they are not implemented yet.
List of options not available in Scala 3 I have removed from the target:
-Xlint
-Ywarn-dead-code
-Ywarn-numeric-widen
-Ywarn-value-discard
-Wunused:imports