update default scalafmt phase order; place before runfiles
#1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liucijus
approved these changes
Feb 8, 2022
Contributor
Author
|
Lemme check why the tool deps are causing a test failure now whereas they weren't previously. I might need to tweak something and will update the PR if so. |
See comments for detailed motivation
virusdave
force-pushed
the
dnicponski/scratch/update_scalafmt_phase_order
branch
from
1502a1f to
8e36f3e
Compare
virusdave
commented
Feb 8, 2022
Comment on lines
+43
to
+47
| "@org_scalameta_common", | ||
| "@org_scalameta_parsers", | ||
| "@org_scalameta_scalafmt_core", | ||
| "@org_scalameta_scalameta", | ||
| "@org_scalameta_trees", |
Contributor
Author
There was a problem hiding this comment.
NB: These are already transitive dependencies of scalafmt_core, but with the new phase position, the test requiring explicitly-specified dependencies requires them to be listed explicitly.
simuons
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See comments in change for detailed motivation. TL;DR: Allow the capture of formatted sources, original sources, and manifest to be passed via
runfilesphase to downstream dependencies, such as a wrappingsh_test, allowing it toactually access those during a
bazel testinvocation and fail a build if the format is incorrect.