Skip to content

Conversation

@basil-squared
Copy link
Owner

@basil-squared basil-squared commented Aug 12, 2025

Summary by Sourcery

Bug Fixes:

  • Remove extra_tabs function that generated the Overclock Info tab in the UI

@basil-squared basil-squared merged commit 7fb821a into main Aug 12, 2025
1 check passed
Repository owner deleted a comment from sourcery-ai bot Aug 12, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @basil-squared - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Simplify main.lua by removing the buggy Overclock UI tab override and adjusting the surrounding code layout, restoring the correct async_exec definition.

Class diagram for removal of Overclock UI tab override

classDiagram
    class SMODS_current_mod {
        optional_features
        extra_tabs // removed
    }
    %% The extra_tabs function was removed from SMODS.current_mod
Loading

File-Level Changes

Change Details Files
Removed Overclock UI tab registration and its helper function
  • Deleted the extra_tabs function that returned the Overclock Info tab
  • Removed the placeholder comment for inserting additional tabs
main.lua
Fixed code layout after removal
  • Outdented the async_exec function to top-level scope
main.lua

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants