Skip to content

Complete command line arguments #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 11, 2021
Merged

Complete command line arguments #294

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
47319f8
Complete command line arguments
otreblan Jun 9, 2021
43c3c93
Prettier
otreblan Jun 9, 2021
3835106
Eslint autofix
otreblan Jun 9, 2021
c93d131
Merge branch 'master' into master
otreblan Jun 9, 2021
7d6916d
Add commandNameAtPoint test
otreblan Jun 9, 2021
c2ec492
Test onCompletion for command options
otreblan Jun 9, 2021
f956526
Trim and filter results
otreblan Jun 13, 2021
25da9ac
Generic way of getting the path to bash_completion
otreblan Jun 13, 2021
0206cb5
set -uo pipefail
otreblan Jun 13, 2021
54527cf
No pipefail
otreblan Jun 13, 2021
d8b2adc
No set
otreblan Jun 13, 2021
f902cf4
Disable _longopt by default
otreblan Jun 13, 2021
682de8a
Return an empty array when get-completions fails
otreblan Jun 13, 2021
3cff08d
Exit get-options.sh if bash-completion isn't installed
otreblan Jul 4, 2021
16ad7d6
Merge branch 'master' into master
skovhus Aug 11, 2021
bf5e329
Merge branch 'master' into master
skovhus Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/src/get-options.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/usr/bin/env bash

source /usr/share/bash-completion/bash_completion
DATADIR="$(pkg-config --variable=datadir bash-completion)"
Copy link
Collaborator

@skovhus skovhus Jul 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the script handle if the user doesn't have the completion installed?

~ pkg-config --variable=datadir bash-completion

package bash-completion was not found in the pkg-config search path.
Perhaps you should add the directory containing `bash-completion.pc'
to the PKG_CONFIG_PATH environment variable
No package 'bash-completion' found

~ echo $?
1

Copy link
Collaborator

@skovhus skovhus Jul 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least on OS X the suggested solution doesn't work. Does the solution works on most Linux distributions?

Copy link
Contributor Author

@otreblan otreblan Jul 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work if the bash-completion package is installed and it provides a bash-completion.pc file.


source "$DATADIR/bash-completion/bash_completion"

COMP_LINE="$*"
COMP_WORDS=("$@")
Expand Down