Add a small note that enabling ssl: true makes kamal-proxy stop forwarding headers unless forward_headers is also set to true
#141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a small note that enabling `ssl: true` makes `kamal-proxy` stop forwarding headers unless `forward_headers` is also set to `true`
djmb
added a commit
to basecamp/kamal
that referenced
this pull request
Dec 13, 2024
Pulled in from: basecamp/kamal-site#141
Contributor
|
Just merging this now, but the docs under docs/configuration are generated from the yml files in the kamal repo. I've updated them here - basecamp/kamal@77c202e and I'll pull that in next time I generate the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially important in the case you're putting your Rails app behind Cloudflare, and are using the
cloudflare-railsgem to get the real userrequest.remote_ip. Without this option, gems likecloudflare-railswill fail to set the right headers and infer the right request IP as discussed in modosc/cloudflare-rails#165