-
Notifications
You must be signed in to change notification settings - Fork 0
Init membit-python #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
README.md
Outdated
|
||
## Requirements | ||
|
||
- **Python:** >=3.12,<3.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we target lower version of Python? requests
supports Python 3.8+. tavily-python
supports Python 3.6+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I use 3.10
due to match/case statement, | None (introduced in Python 3.10)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I prefer we define specific type for response (maybe use Pydantic) instead of using generic dict
, but that can be done in other PRs.
No description provided.