Skip to content

Conversation

@pdcastro
Copy link
Contributor

@pdcastro pdcastro commented Apr 22, 2020

Fix the following warnings (result of PR #1739):

$ npm install -g --production balena-cli
...
Applying patches...
No patch files found
patch-package 6.2.2
Applying patches...
@oclif/[email protected][email protected][email protected] ✔

Warning: patch-package detected a patch file version mismatch

  Don't worry! This is probably fine. The patch was still applied
  successfully. Here's the deets:

  Patch file created for

    [email protected]

  applied to

    [email protected]

  At path

    node_modules/pkg

  This warning is just to give you a heads-up. There is a small chance of
  breakage even though the patch was applied successfully. Make sure the package
  still behaves like you expect (you wrote tests, right?) and then run

    patch-package pkg

  to update the version in the patch file name and make this warning go away.

qqjs/[email protected] ✔

Warning: patch-package detected a patch file version mismatch

  Don't worry! This is probably fine. The patch was still applied
  successfully. Here's the deets:

  Patch file created for

    [email protected]

  applied to

    [email protected]

  At path

    node_modules/qqjs

  This warning is just to give you a heads-up. There is a small chance of
  breakage even though the patch was applied successfully. Make sure the package
  still behaves like you expect (you wrote tests, right?) and then run

    patch-package qqjs

  to update the version in the patch file name and make this warning go away.

[email protected]

Change-type: patch

"build/",
"doc/",
"lib/",
"patches0/",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad to have forgotten to add this line here. I had tested the release assets of PR #1739 (standalone zip packages, macOS installer, Windows installer) but I forgot to test npm install -g --production. Luckily the consequence is limited to the warning message during the installation.

@pdcastro pdcastro merged commit 81c5a62 into master Apr 22, 2020
@pdcastro pdcastro deleted the npm-files-patches0 branch April 22, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants