Fix seemingly random ENOENT error (update 'is-installed-globally' dependency) #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endency) Change-type: patch Resolves: #1723
pdcastro
requested review from
CameronDiver,
hedss,
srlowe and
thgreasi
as code owners
hedss
approved these changes
Apr 15, 2020
|
note: the possibility for this issue was introduced in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is-installed-globallyversion 0.3.2 fixed the ENOENT issue:The CLI's
npm-shrinkwrap.jsonfile has two occurrences of affectedis-installed-globallydependency:This PR updates the first one, but leaves
is-installed-globallyv0.1.0 alone: there is a net of dependencies that I couldn't untangle. Even so, strictly this PR resolves issue #1723 because that issue qualified the problem as "when running cli commands", and the v0.1.0 dependency only applies when runningpatch-packagein thepostinstallnpm script.patch-packagev6.2.1 resolves the problem by removing the dependency altogether, but we cannot upgrade frompatch-package6.1 to 6.2 because of issue ds300/patch-package/issues/201. I created PR ds300/patch-package/pull/224 in their repo, which hopefully would allow us to upgradepatch-package. Meanwhile, this PR should alleviate the problem.Change-type: patch
Resolves: #1723