Skip to content

Conversation

@jcundill
Copy link
Contributor

partial fix for #192

Accidentally changed the loader function definition with the cucumber.json PR - revert to previous way it was called to sort out the 'this' resolution when called from webpack.

Note: there are still issues with the typescript webpack example due to the use of the jsonFormatter module browser side

To fix this and get the typescript webpack example running again I had to identify some modules in the webpack config in that example as empty

module.exports = {
  resolve: {
    extensions: [".ts", ".js"]
  },
  node: { fs: "empty", child_process: "empty", readline: "empty" },  <--- fixes the webpack example
  module: {
    rules: [
      {
        test: /\.ts$/,
        exclude: [/node_modules/],
        use: [
          {
            loader: "ts-loader"
          }
        ]
      },
      {
        test: /\.feature$/,
        use: [
          {
            loader: "cypress-cucumber-preprocessor/loader"
          }
        ]
      }
    ]
  }
};

see Asana/node-asana#114 (comment) for discussion of this.

There may be a neater way to get the webpack loader example working again without this addition

@lgandecki lgandecki merged commit 158ef02 into badeball:master Jul 25, 2019
@lgandecki
Copy link
Collaborator

Ok, I will look closer tomorrow, thanks for all the info!

@jcundill jcundill deleted the upstream_master branch July 25, 2019 22:30
@LeroyDoornebal
Copy link

Thanks @jcundill! Was walking into this exact same issue. I'll downgrade again until the release of this fix :)

lgandecki added a commit that referenced this pull request Aug 9, 2019
There was an issue with a patch release, so this manual-releases.md
change is to release a new patch version.

Reference: #193
@lgandecki
Copy link
Collaborator

🎉 This PR is included in version 1.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants