Migrate to Helios #199
Draft
Migrate to Helios #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysterious console errors about decorators? But it works… sometimes.
Test Results112 tests +6 111 ✅ +6 25s ⏱️ - 1m 2s Results for commit 6566f57. ± Comparison against base commit ff403ce. This pull request removes 2 and adds 8 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
# Conflicts: # package-lock.json
I couldn’t get the application to run anymore, maybe something about pnpm…? ugh. But now I can replace components one at a time.
This makes the application render at least, very little to show since all the Ember Paper components are empty, but without this there was an `decorator is not a function` error that would abort rendering.
or forever?
it’s a start!
There’s a focus trap problem with the modal, which is a major aspect of this, something to continue on.
It seems like it might have been working but 1.1.1 says it needs Ember 4.16 which I’m not on.
This has rendering weirdness and I couldn’t figure out how to get page objects to fit the structure 😞
This will need further cleanup.
whew!
whew! Another failing test but mostly working
This actually adds functionality…? scandal, but I’m not sure why I didn’t include the requires confirmation count before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #184.
selectChooseinside page objects?