Explicitly define NodePath.prototype.*

[liuxingbaoyu]

Q	A
Fixed Issues?	Ref: #16443
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56905

[nicolo-ribaudo]

Thanks! Could you declare this object outside of Object.assign, and then use it for NodePathMixins below so that they use the same data source?

const methods = {
  findParent: findParent: NodePath_ancestry.findParent,
  // ...
}
Object.assign(NodePath_Final.prototype, methods);

type NodePathMixins = Omit<typeof methods, keyof NodePathOverwrites>;

[nicolo-ribaudo]

Please keep this in a separate statement, otherwise TS will include its type also in the Babel 8 build.

[nicolo-ribaudo]

Thanks!

After this, could you open a new PR removing in Babel 8

• all the methods that start in _
• all the methods that are not used outside of @babel/traverse?

[liuxingbaoyu]

Sure! I'm a little unsure if anyone is using methods starting with _, but it probably doesn't matter.

[nicolo-ribaudo]

Well _ usually means "private" -- if they need it they can open an issue and we can talk about making it part of the public API.

[nicolo-ribaudo]

Could you rebase this on top of main and make sure that it still type checks properly? :)

[liuxingbaoyu]

The CI failure is from node v22.2.0.

Ref: nodejs/node#52827

Reported in nodejs/node#53011