Skip to content

backport #1034 to 9.x #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2024
Merged

backport #1034 to 9.x #1037

merged 1 commit into from
Sep 16, 2024

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 3, 2024

Backported #1034 to the 9.x branch.

JLHwung added a commit that referenced this pull request Sep 3, 2024
@JLHwung
backport #1037 to 8.x
967cee4 
# Conflicts:
#	src/cache.js
#	src/index.js
@JLHwung JLHwung mentioned this pull request Sep 3, 2024
Merged
9 tasks
@JLHwung JLHwung requested review from liuxingbaoyu and nicolo-ribaudo and removed request for nicolo-ribaudo September 4, 2024 14:18
@liuxingbaoyu
Copy link
Member

liuxingbaoyu commented Sep 4, 2024

Can't we just rebase 9.x?

@JLHwung
Copy link
Contributor Author

JLHwung commented Sep 4, 2024

Can't we just rebase 9.x?

I am afraid not. There have already been a few breaking changes in the current main branch:

#909
#1026
#1027

So I have to cut the 9.x branch from e449287

@JLHwung JLHwung mentioned this pull request Sep 12, 2024
Merged
@nicolo-ribaudo nicolo-ribaudo merged commit a1a24ca into 9.x Sep 16, 2024
nicolo-ribaudo pushed a commit that referenced this pull request Sep 16, 2024
@JLHwung
Backport #1037 to 8.x (#1039)
945b7ed
@Faisalsc Faisalsc mentioned this pull request Oct 8, 2024
Open
@xorinzor xorinzor mentioned this pull request Oct 8, 2024
Merged
@Loonz206 Loonz206 mentioned this pull request Oct 16, 2024
Merged
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 24, 2024
Open
@mkh1n mkh1n mentioned this pull request Oct 25, 2024
Open
@keyasuda keyasuda mentioned this pull request Oct 26, 2024
Merged
@mend-for-github-com mend-for-github-com bot mentioned this pull request Oct 31, 2024
Open
1 task
@mkh1n mkh1n mentioned this pull request Nov 1, 2024
Open
@mkh1n mkh1n mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

@nicolo-ribaudo nicolo-ribaudo Awaiting requested review from nicolo-ribaudo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JLHwung @liuxingbaoyu @nicolo-ribaudo