Added method parameter to stubRequest
#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jsdoc comment mentioned the posibility to specify what method to stub, but the actual code didn't support it. Now it does. To match the documentation and other stub functions the `method` parameter is the first parameter. To keep the code backwards compatible this parameter needed to be optional. That unfortunately made the actual implementation a litte bit messy. Fixes #5
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jsdoc comment mentioned the posibility to specify what method to
stub, but the actual code didn't support it. Now it does.
To match the documentation and other stub functions the
methodparameter is the first parameter. To keep the code backwards
compatible this parameter needed to be optional. That unfortunately
made the actual implementation a litte bit messy.
Fixes #5