Skip to content

Conversation

@hakuna-matatah
Copy link
Contributor

@hakuna-matatah hakuna-matatah commented Aug 28, 2025

Issue #, if available:

Description of changes:

Place holder for tekton tasks to run aiml workloads.

These tasks will be hooked into ai/ml test pipeline once karpenter related tekton tasks are merged.

I will scrub these tasks as follow up, once i have karpenter tekton tasks in place.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

echo "0" | tee $(results.datapoint.path)
fi
exit $exit_code
timeout: 30000s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be way too long.

- sh
- -c
- |
#ToDo remove this once PIA is compliant with exit criteria
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. If it's still not, we need to find someone to work on it.

- sh
- -c
- |
#ToDo remove this once PIA is compliant with exit criteria
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

echo "0" | tee $(results.datapoint.path)
fi
exit $exit_code
timeout: 30000s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way too long.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what is being used across the board today in all tasks, this will be no-op because we have timeouts at cl2 test level itself.

image: golang:1.24
workingDir: $(workspaces.source.path)
script: |
S3_RESULT_PATH=$(params.results-bucket)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to avoid duplication here and below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which below ? not sure i follow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very similar to the same step in tests/tekton-resources/tasks/generators/clusterloader/load-aiml-large-pre-training.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants