- 
                Notifications
    You must be signed in to change notification settings 
- Fork 47
Tekon tasks for running AI/ML workloads #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
        
          
                tests/tekton-resources/tasks/generators/clusterloader/load-aiml-multiple-fine-tuning.yaml
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | echo "0" | tee $(results.datapoint.path) | ||
| fi | ||
| exit $exit_code | ||
| timeout: 30000s | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be way too long.
| - sh | ||
| - -c | ||
| - | | ||
| #ToDo remove this once PIA is compliant with exit criteria | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. If it's still not, we need to find someone to work on it.
| - sh | ||
| - -c | ||
| - | | ||
| #ToDo remove this once PIA is compliant with exit criteria | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
        
          
                tests/tekton-resources/tasks/generators/clusterloader/load-aiml-large-pre-training.yaml
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                tests/tekton-resources/tasks/generators/clusterloader/load-aiml-large-pre-training.yaml
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | echo "0" | tee $(results.datapoint.path) | ||
| fi | ||
| exit $exit_code | ||
| timeout: 30000s | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way too long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is what is being used across the board today in all tasks, this will be no-op because we have timeouts at cl2 test level itself.
| image: golang:1.24 | ||
| workingDir: $(workspaces.source.path) | ||
| script: | | ||
| S3_RESULT_PATH=$(params.results-bucket) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to avoid duplication here and below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which below ? not sure i follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very similar to the same step in tests/tekton-resources/tasks/generators/clusterloader/load-aiml-large-pre-training.yaml
        
          
                tests/tekton-resources/tasks/generators/clusterloader/load-aiml-multiple-fine-tuning.yaml
              
                Outdated
          
            Show resolved
            Hide resolved
        
      f169cb4    to
    dced163      
    Compare
  
    
Issue #, if available:
Description of changes:
Place holder for tekton tasks to run aiml workloads.
These tasks will be hooked into ai/ml test pipeline once karpenter related tekton tasks are merged.
I will scrub these tasks as follow up, once i have karpenter tekton tasks in place.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.