-
Notifications
You must be signed in to change notification settings - Fork 47
Add custom authenticator support #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| func IsNetIOTimeOut(err error) bool { | ||
| netErr := net.Error(nil) | ||
| return errors.As(err, &netErr) && netErr.Temporary() && netErr.Timeout() | ||
| return errors.As(err, &netErr) && netErr.Timeout() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this error with the newest version of the go linter:
pkg/errors/errors.go:46:36: SA1019: netErr.Temporary has been deprecated since Go 1.18 because it shouldn't be used: Temporary errors are not well-defined. Most "temporary" errors are timeouts, and the few exceptions are surprising. Do not use this method. (staticcheck)
return errors.As(err, &netErr) && netErr.Temporary() && netErr.Timeout()
^
| # * export GUEST_CLUSTER_NAME="foobar" | ||
| # * envsubst < auth-stage2.yaml | kubectl --kubeconfig $KUBECONFIG apply -f - | ||
|
|
||
| apiVersion: kit.k8s.sh/v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have tested this example spec right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Forgot to rename auth-stage2.yaml back to custom-authenticator.yaml after though. I'll update it.
prateekgogia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Nice job Alex! |
| name: $GUEST_CLUSTER_NAME | ||
| spec: | ||
| master: | ||
| apiServer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's just very confusing. There are 3 kubeconfigish flags for the authenticator:
--kubeconfig-> this is configuring one direction communication from authenticator to kube-apiserver--generate-kubeconfig-> this is configuring communication from kube-apiserver to authenticator (this is the token file passed here.--kubeconfig-pregenerated-> a boolean flag if we don't want the--kubeconfigflag to generate a new kubeconfig.
I'll add a comment elaborating on this in the yaml.
1655f36 to
21f32bc
Compare
Issue #, if available:
Description of changes:
Testing:
Deployed kit changes:
Created cluster and validated backend modes were updated (notice MountedFile and EKSConfigMap mappers)
Created the
aws-authconfigmap in the guest cluster and validated access changes.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.