Update to Microsoft.Extensions.AI.Abstractions 9.8.0 #3960

stephentoub · 2025-08-15T14:58:47Z

Description

Updated to the latest M.E.AI.Abstractions release
Set new ChatMessage.CreatedAt property
Set and use new DataContent.Name property
Added citations to BedrockChatClient
Added implementation of IImageGenerator (as [Experimental] because the interface is itself [Experimental])

Motivation and Context

Light-up new surface area in Microsoft.Extensions.AI.Abstractions.

Testing

Manual testing against various models with basic scenarios.

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

My code follows the code style of this project
My change requires a change to the documentation
I have updated the documentation accordingly
I have read the README document
I have added tests to cover my changes
All new and existing tests passed

License

I confirm that this pull request can be released under the Apache 2 license

- Set new ChatMessage.CreatedAt property - Set and use new DataContent.Name property - Added citations to BedrockChatClient - Added implementation of IImageGenerator (as [Experimental] because the interface is itself [Experimental])

ericstj

I think we should be able to plumb edit/variation as well.

ericstj · 2025-08-15T15:27:19Z

extensions/src/AWSSDK.Extensions.Bedrock.MEAI/BedrockImageGenerator.cs

+            }
+            else
+            {
+                // Amazon models (e.g. Titan, Nova Canvas)


These also support a starting image -- https://docs.aws.amazon.com/bedrock/latest/userguide/model-parameters-titan-image.html

ericstj · 2025-08-15T15:29:20Z

extensions/src/AWSSDK.Extensions.Bedrock.MEAI/BedrockImageGenerator.cs

+
+            if (invokeRequest.ModelId?.IndexOf("stability", StringComparison.OrdinalIgnoreCase) >= 0)
+            {
+                // Stability AI models


Stability models should also permit a starting image we should pass that in for edit. https://docs.aws.amazon.com/bedrock/latest/userguide/model-parameters-diffusion-3-text-image.html

Copilot

Pull Request Overview

This PR updates the Microsoft.Extensions.AI.Abstractions package from version 9.7.0 to 9.8.0 and implements new features enabled by the updated library. The changes include setting new ChatMessage properties, handling citations in responses, and adding experimental image generation capabilities.

Updates Microsoft.Extensions.AI.Abstractions dependency to version 9.8.0 across all project files
Adds citation support to BedrockChatClient for both streaming and non-streaming responses
Implements experimental IImageGenerator interface with support for multiple image generation models

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
BedrockMEAITests.NetFramework.csproj	Updates test project dependency to version 9.8.0
ExperimentalAttribute.cs	Adds polyfill for [Experimental] attribute for non-.NET targets
BedrockImageGenerator.cs	Implements IImageGenerator interface with support for Stability AI and Amazon image models
BedrockChatClient.cs	Adds CreatedAt property setting, citation handling, and DataContent.Name property usage
AmazonBedrockRuntimeExtensions.cs	Adds AsIImageGenerator extension method marked as experimental
AWSSDK.Extensions.Bedrock.MEAI.nuspec	Updates package dependency references to version 9.8.0
AWSSDK.Extensions.Bedrock.MEAI.NetStandard.csproj	Updates package reference to version 9.8.0
AWSSDK.Extensions.Bedrock.MEAI.NetFramework.csproj	Updates package reference to version 9.8.0

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-19T17:13:08Z

extensions/src/AWSSDK.Extensions.Bedrock.MEAI/BedrockImageGenerator.cs

+                if (element.TryGetProperty("base64", out JsonElement base64Element) &&
+                    base64Element.ValueKind == JsonValueKind.String)
+                {
+                    result.Contents.Add(new DataContent(Convert.FromBase64String(base64Element.GetString()!), "image/png"));


The MIME type is hardcoded as 'image/png' but different models may return different image formats. Consider determining the actual format from the response or making it configurable.

Suggested change

result.Contents.Add(new DataContent(Convert.FromBase64String(base64Element.GetString()!), "image/png"));

string mimeType = "image/png";

if (element.TryGetProperty("mime_type", out JsonElement mimeTypeElement) && mimeTypeElement.ValueKind == JsonValueKind.String)

{

mimeType = mimeTypeElement.GetString()!;

}

else if (element.TryGetProperty("type", out JsonElement typeElement) && typeElement.ValueKind == JsonValueKind.String)

{

mimeType = typeElement.GetString()!;

}

result.Contents.Add(new DataContent(Convert.FromBase64String(base64Element.GetString()!), mimeType));

Copilot · 2025-08-19T17:13:09Z

extensions/src/AWSSDK.Extensions.Bedrock.MEAI/BedrockImageGenerator.cs

+            {
+                if (image.ValueKind == JsonValueKind.String)
+                {
+                    result.Contents.Add(new DataContent(Convert.FromBase64String(image.GetString()!), "image/png"));


The MIME type is hardcoded as 'image/png' but different models may return different image formats. Consider determining the actual format from the response or making it configurable.

Suggested change

result.Contents.Add(new DataContent(Convert.FromBase64String(image.GetString()!), "image/png"));

{

var imageBytes = Convert.FromBase64String(image.GetString()!);

var mimeType = ImageFormatHelper.GetImageMimeType(imageBytes);

result.Contents.Add(new DataContent(imageBytes, mimeType));

}

Copilot · 2025-08-19T17:13:09Z

extensions/src/AWSSDK.Extensions.Bedrock.MEAI/BedrockChatClient.cs

+                            Title = citations.Citations![i].Title,
+                            Snippet = citations.Citations![i].SourceContent?.Select(c => c.Text).FirstOrDefault(),
+                        }];
+                        result.Contents.Add(tc);


Potential null reference exception when citations.Content[i] is null. The null-forgiving operator ! is used but citations.Content[i] could still be null even after the count check.

Suggested change

result.Contents.Add(tc);

if (citations.Content![i] != null)

{

TextContent tc = new(citations.Content[i]?.Text) { RawRepresentation = citations.Content[i] };

tc.Annotations = [new CitationAnnotation()

{

Title = citations.Citations![i].Title,

Snippet = citations.Citations![i].SourceContent?.Select(c => c.Text).FirstOrDefault(),

}];

result.Contents.Add(tc);

}

Copilot · 2025-08-19T17:13:10Z

extensions/src/AWSSDK.Extensions.Bedrock.MEAI/BedrockChatClient.cs

+                            Title = citations.Citations![i].Title,
+                            Snippet = citations.Citations![i].SourceContent?.Select(c => c.Text).FirstOrDefault(),
+                        }];
+                        result.Contents.Add(tc);


Potential null reference exception when citations.Citations[i] is null. The null-forgiving operator ! is used but citations.Citations[i] could still be null even after the count check.

Suggested change

result.Contents.Add(tc);

var contentItem = citations.Content![i];

var citationItem = citations.Citations![i];

if (contentItem != null && citationItem != null)

{

TextContent tc = new(contentItem.Text) { RawRepresentation = contentItem };

tc.Annotations = [new CitationAnnotation()

{

Title = citationItem.Title,

Snippet = citationItem.SourceContent?.Select(c => c.Text).FirstOrDefault(),

}];

result.Contents.Add(tc);

}

Copilot · 2025-08-19T17:13:10Z

extensions/src/AWSSDK.Extensions.Bedrock.MEAI/BedrockChatClient.cs

+                            Title = citations.Citations![i].Title,
+                            Snippet = citations.Citations![i].SourceContent?.Select(c => c.Text).FirstOrDefault(),
+                        }];
+                        result.Contents.Add(tc);


Potential null reference exception when citations.Citations[i] is null. The null-forgiving operator ! is used but citations.Citations[i] could still be null even after the count check.

Suggested change

result.Contents.Add(tc);

var citation = citations.Citations![i];

var contentItem = citations.Content![i];

if (citation != null && contentItem != null)

{

TextContent tc = new(contentItem.Text) { RawRepresentation = contentItem };

tc.Annotations = [new CitationAnnotation()

{

Title = citation.Title,

Snippet = citation.SourceContent?.Select(c => c.Text).FirstOrDefault(),

}];

result.Contents.Add(tc);

}

GarrettBeatty · 2025-08-19T17:44:27Z

extensions/src/AWSSDK.Extensions.Bedrock.MEAI/BedrockChatClient.cs

@@ -97,6 +98,21 @@ public async Task<ChatResponse> GetResponseAsync(
                    result.Contents.Add(new TextContent(text) { RawRepresentation = content });
                }

+                if (content.CitationsContent is { } citations)


im not a huge fan of the ! null checks everywhere (unless there was a specific reason you needed them?). wondering if we can do something like below instead?

i havent tested it but it gives the general idea

if (content.CitationsContent is { } citations) { for (int i = 0; i < Math.Min(citations.Citations?.Count ?? 0, citations.Content?.Count ?? 0); i++) { var contentItem = citations.Content?[i]; var citationItem = citations.Citations?[i]; if (contentItem != null && citationItem != null) { TextContent tc = new(contentItem.Text) { RawRepresentation = contentItem }; tc.Annotations = new[] { new CitationAnnotation { Title = citationItem.Title, Snippet = citationItem.SourceContent?.Select(c => c.Text).FirstOrDefault(), } }; result.Contents.Add(tc); } } }

same in other places

GarrettBeatty · 2025-08-19T17:46:56Z

extensions/test/BedrockMEAITests/BedrockMEAITests.NetFramework.csproj

@@ -18,7 +18,7 @@
  </PropertyGroup>



can we add tests for the citation changes?

Update to M.E.AI 9.8

06fcca8

- Set new ChatMessage.CreatedAt property - Set and use new DataContent.Name property - Added citations to BedrockChatClient - Added implementation of IImageGenerator (as [Experimental] because the interface is itself [Experimental])

ericstj reviewed Aug 15, 2025

View reviewed changes

GarrettBeatty requested review from GarrettBeatty, Copilot and normj August 19, 2025 17:11

Copilot AI reviewed Aug 19, 2025

View reviewed changes

GarrettBeatty reviewed Aug 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update to Microsoft.Extensions.AI.Abstractions 9.8.0 #3960

Update to Microsoft.Extensions.AI.Abstractions 9.8.0 #3960

Uh oh!

stephentoub commented Aug 15, 2025

Uh oh!

ericstj left a comment

Uh oh!

ericstj Aug 15, 2025

Uh oh!

ericstj Aug 15, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 19, 2025

Uh oh!

Copilot AI Aug 19, 2025

Uh oh!

Copilot AI Aug 19, 2025

Uh oh!

Copilot AI Aug 19, 2025

Uh oh!

Copilot AI Aug 19, 2025

Uh oh!

GarrettBeatty Aug 19, 2025

Uh oh!

GarrettBeatty Aug 19, 2025

Uh oh!

Uh oh!

-                    result.Contents.Add(new DataContent(Convert.FromBase64String(base64Element.GetString()!), "image/png"));
+                    string mimeType = "image/png";
+                    if (element.TryGetProperty("mime_type", out JsonElement mimeTypeElement) && mimeTypeElement.ValueKind == JsonValueKind.String)
+                    {
+                        mimeType = mimeTypeElement.GetString()!;
+                    }
+                    else if (element.TryGetProperty("type", out JsonElement typeElement) && typeElement.ValueKind == JsonValueKind.String)
+                    {
+                        mimeType = typeElement.GetString()!;
+                    }
+                    result.Contents.Add(new DataContent(Convert.FromBase64String(base64Element.GetString()!), mimeType));

-                    result.Contents.Add(new DataContent(Convert.FromBase64String(image.GetString()!), "image/png"));
+                    {
+                        var imageBytes = Convert.FromBase64String(image.GetString()!);
+                        var mimeType = ImageFormatHelper.GetImageMimeType(imageBytes);
+                        result.Contents.Add(new DataContent(imageBytes, mimeType));
+                    }

-                        result.Contents.Add(tc);
+                        var contentItem = citations.Content![i];
+                        var citationItem = citations.Citations![i];
+                        if (contentItem != null && citationItem != null)
+                        {
+                            TextContent tc = new(contentItem.Text) { RawRepresentation = contentItem };
+                            tc.Annotations = [new CitationAnnotation()
+                            {
+                                Title = citationItem.Title,
+                                Snippet = citationItem.SourceContent?.Select(c => c.Text).FirstOrDefault(),
+                            }];
+                            result.Contents.Add(tc);
+                        }

Update to Microsoft.Extensions.AI.Abstractions 9.8.0 #3960

Are you sure you want to change the base?

Update to Microsoft.Extensions.AI.Abstractions 9.8.0 #3960

Uh oh!

Conversation

stephentoub commented Aug 15, 2025

Description

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

Checklist

License

Uh oh!

ericstj left a comment

Choose a reason for hiding this comment

Uh oh!

ericstj Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

ericstj Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

GarrettBeatty Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

GarrettBeatty Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!