Generate copy part #3951

peterrsongg · 2025-08-12T16:35:31Z

Description

Generates CopyPart (UploadPartCopy)

Motivation and Context

Testing

DRY_RUN-af4c3b28-315f-4b35-bbda-b8fe124c50cd

1 breaking change (bool => bool?) which I call out

AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CopyPartResponse/MethodAdded: New method System.String get_SSECustomerKeyMD5() in Amazon.S3.Model.CopyPartResponse
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CopyPartResponse/MethodAdded: New method System.Void set_SSECustomerKeyMD5(System.String) in Amazon.S3.Model.CopyPartResponse
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CopyPartResponse/MethodAdded: New method System.String get_SSECustomerAlgorithm() in Amazon.S3.Model.CopyPartResponse
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CopyPartResponse/MethodAdded: New method Amazon.S3.RequestCharged get_RequestCharged() in Amazon.S3.Model.CopyPartResponse
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CopyPartResponse/MethodAdded: New method System.Void set_SSECustomerAlgorithm(System.String) in Amazon.S3.Model.CopyPartResponse
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CopyPartResponse/MethodAdded: New method System.Void set_RequestCharged(Amazon.S3.RequestCharged) in Amazon.S3.Model.CopyPartResponse
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.CopyPartResponse/MethodRemoved: Missing method System.Void set_BucketKeyEnabled(System.Boolean) in Amazon.S3.Model.CopyPartResponse
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CopyPartResponse/MethodAdded: New method System.Void set_BucketKeyEnabled(System.Nullable<System.Boolean>) in Amazon.S3.Model.CopyPartResponse
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.CopyPartResponse/MethodRemoved: Missing method System.Boolean get_BucketKeyEnabled() in Amazon.S3.Model.CopyPartResponse
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CopyPartResponse/MethodAdded: New method System.Nullable<System.Boolean> get_BucketKeyEnabled() in Amazon.S3.Model.CopyPartResponse

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

My code follows the code style of this project
My change requires a change to the documentation
I have updated the documentation accordingly
I have read the README document
I have added tests to cover my changes
All new and existing tests passed

License

I confirm that this pull request can be released under the Apache 2 license

peterrsongg · 2025-08-12T16:38:01Z

generator/ServiceClientGeneratorLib/Customizations.cs

@@ -1087,20 +1086,6 @@ public ShapeModifier(JsonData data)
            //        }
            //   },
            // Above is an example of how to specify the originalMember on the injected member.
-            private void Validate(JsonData data)


I added this when I was working on splitting GetACL PutACL into their respective GetObjectACL and GetBucketACL a while back because I thought if we were excluding a member we would always be injecting another member and referencing the original member that the injected member is referencing. However, as I started to generate more S3 operations I realize that this is not always the case. Sometimes we exclude a member and inject a member but that member doesn't reference an "originalMember" at all.

peterrsongg · 2025-08-12T20:00:06Z

~~let's hold off on reviewing this until the other PR that was reverted is merged in~~
Dry run passed: d33ff46c-a0b4-41c3-bddb-c85f9d73fa66

Copilot

Pull Request Overview

This PR generates the CopyPart (UploadPartCopy) operation for the AWS S3 SDK, adding support for multipart upload copying functionality. The implementation includes both request marshalling and response unmarshalling components, along with customizations to handle S3-specific requirements.

Generate CopyPart operation code from service model
Refactor existing custom code to use generated components with partial classes
Update customizations to support flattened shapes and proper marshalling

Reviewed Changes

Copilot reviewed 12 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
CopyPartResponseUnmarshaller.cs	Removes entire custom unmarshaller implementation to allow generation
CopyPartRequestMarshaller.cs	Converts to partial class and moves logic to PostMarshallCustomization method
CopyPartResponse.cs	Converts to partial class, removing most properties to allow generation
CopyPartRequest.cs	Converts to partial class, keeping only custom range properties
s3.customizations.json	Adds extensive customizations for UploadPartCopy operation marshalling
ServiceModel.cs	Enables UploadPartCopy operation in S3 allow list
RestXmlResponseUnmarshaller.tt	Adds support for flattened shapes in response unmarshalling
BaseResponseUnmarshaller.tt	Adds check to skip flattened shape members during unmarshalling
Customizations.cs	Removes validation that was blocking the customization approach

Comments suppressed due to low confidence (1)

generator/ServiceClientGeneratorLib/Customizations.cs:1069

Removing the validation entirely could allow invalid customizations to pass through undetected. Consider replacing this with a more flexible validation that handles the specific case being addressed rather than removing all validation.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-14T00:01:42Z

sdk/src/Services/S3/Custom/Model/Internal/MarshallTransformations/CopyPartRequestMarshaller.cs

@@ -27,92 +27,8 @@ namespace Amazon.S3.Model.Internal.MarshallTransformations
    /// <summary>
    /// Upload Part Copy Request Marshaller
    /// </summary>       
-    public class CopyPartRequestMarshaller : IMarshaller<IRequest, CopyPartRequest> ,IMarshaller<IRequest,Amazon.Runtime.AmazonWebServiceRequest>
+    public partial class CopyPartRequestMarshaller : IMarshaller<IRequest, CopyPartRequest> ,IMarshaller<IRequest,Amazon.Runtime.AmazonWebServiceRequest>


[nitpick] There should be a space after the comma in the interface implementation list for consistency with C# formatting conventions.

Suggested change

public partial class CopyPartRequestMarshaller : IMarshaller<IRequest, CopyPartRequest> ,IMarshaller<IRequest,Amazon.Runtime.AmazonWebServiceRequest>

public partial class CopyPartRequestMarshaller : IMarshaller<IRequest, CopyPartRequest>, IMarshaller<IRequest, Amazon.Runtime.AmazonWebServiceRequest>

generator/ServiceModels/s3/s3.customizations.json

GarrettBeatty · 2025-08-14T00:07:58Z

generator/.DevConfigs/fc91462d-3430-4b70-bc03-4363f2696619.json

+      "type": "patch",
+      "changeLogMessages": [
+        "Generate CopyPart.",
+        "[Breaking Change] Amazon.S3.Model.CopyPartResponse's BucketKeyEnabled will not return bool? instead of bool, in line with other S3 nullable types."


if its breaking change should it be minor or what have we been doing for other breaking changes?

the other ones were also just patches so i made this a patch. I think it is okay because we call it out explicitly here and it is what all the other services are doing, we just missed S3 b/c it is handcoded

I agree that we should make it minor.

GarrettBeatty · 2025-08-14T00:10:31Z

generator/ServiceModels/s3/s3.customizations.json

                }
            ],
            "exclude": [
                "CopySource",
-                "Key"
+                "Key",
+                "CopySourceRange"
            ],


does this need any changes? not really 100% sure what its saying but please confirm @peterrsongg (see copilots other comment)

muhammad-othman · 2025-08-15T14:27:32Z

generator/.DevConfigs/fc91462d-3430-4b70-bc03-4363f2696619.json

+      "type": "patch",
+      "changeLogMessages": [
+        "Generate CopyPart.",
+        "[Breaking Change] Amazon.S3.Model.CopyPartResponse's BucketKeyEnabled will not return bool? instead of bool, in line with other S3 nullable types."


I agree that we should make it minor.

peterrsongg · 2025-08-15T17:48:20Z

im gonna hold off on merging until the bug fix is out so we don't have 2 s3 changes going out at once

Generate copy part

8d5ef47

peterrsongg commented Aug 12, 2025

View reviewed changes

Update devconfig to call out breaking change

1ea59b8

GarrettBeatty requested review from GarrettBeatty, muhammad-othman and Copilot August 12, 2025 17:31

This comment was marked as outdated.

Sign in to view

GarrettBeatty requested a review from Copilot August 14, 2025 00:01

Copilot AI reviewed Aug 14, 2025

View reviewed changes

GarrettBeatty reviewed Aug 14, 2025

View reviewed changes

peterrsongg requested a review from GarrettBeatty August 14, 2025 18:43

GarrettBeatty approved these changes Aug 14, 2025

View reviewed changes

muhammad-othman approved these changes Aug 15, 2025

View reviewed changes

fix typo in devconfig.

7c77dfb

peterrsongg merged commit 12f9f9f into development Aug 18, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Generate copy part #3951

Generate copy part #3951

Uh oh!

peterrsongg commented Aug 12, 2025 •

edited

Loading

Uh oh!

peterrsongg Aug 12, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

peterrsongg commented Aug 12, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 14, 2025

Uh oh!

Uh oh!

GarrettBeatty Aug 14, 2025

Uh oh!

peterrsongg Aug 14, 2025

Uh oh!

muhammad-othman Aug 15, 2025

Uh oh!

GarrettBeatty Aug 14, 2025 •

edited

Loading

Uh oh!

muhammad-othman Aug 15, 2025

Uh oh!

peterrsongg commented Aug 15, 2025

Uh oh!

Uh oh!

Uh oh!

	public partial class CopyPartRequestMarshaller : IMarshaller<IRequest, CopyPartRequest> ,IMarshaller<IRequest,Amazon.Runtime.AmazonWebServiceRequest>
	public partial class CopyPartRequestMarshaller : IMarshaller<IRequest, CopyPartRequest>, IMarshaller<IRequest, Amazon.Runtime.AmazonWebServiceRequest>

Generate copy part #3951

Generate copy part #3951

Uh oh!

Conversation

peterrsongg commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

Checklist

License

Uh oh!

peterrsongg Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

peterrsongg commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

GarrettBeatty Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

peterrsongg Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

muhammad-othman Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

GarrettBeatty Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

muhammad-othman Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

peterrsongg commented Aug 15, 2025

Uh oh!

Uh oh!

Uh oh!

peterrsongg commented Aug 12, 2025 •

edited

Loading

peterrsongg Aug 12, 2025 •

edited

Loading

peterrsongg commented Aug 12, 2025 •

edited

Loading

GarrettBeatty Aug 14, 2025 •

edited

Loading