Updated the build to package AWSSDK.Extensions.CborProtocol and notice file updates. #3914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boblodgett
changed the title
muhammad-othman
force-pushed
the
muhamoth/DOTNET-8161-cbor-response-unmarshallers
branch
2 times, most recently
from
241892b to
2ece81a
Compare
muhammad-othman
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
Reviewed the two commits created by Bo, the conflicts are related to ongoing changes in the base branch while I will fix after merging #3905
dscpinheiro
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
There are newer 9.0.x versions of the Cbor dependency available: https://www.nuget.org/packages/System.Formats.Cbor
We should update them before merging the feature branch to development.
muhammad-othman
changed the base branch from
muhamoth/DOTNET-8161-cbor-response-unmarshallers
to
cbor-protocol
muhammad-othman
force-pushed
the
boblod-cbor-buildsys
branch
from
8026b74 to
9eaf86e
Compare
dscpinheiro
approved these changes
Jul 16, 2025
10 tasks
muhammad-othman
pushed a commit
that referenced
this pull request
Aug 5, 2025
…e file updates. (#3914) * Updated notice files for system.formats.cbor. * Updated the build to package AWSSDK.Extensions.CborProtocol.
muhammad-othman
pushed a commit
that referenced
this pull request
Aug 12, 2025
…e file updates. (#3914) * Updated notice files for system.formats.cbor. * Updated the build to package AWSSDK.Extensions.CborProtocol.
muhammad-othman
pushed a commit
that referenced
this pull request
Aug 12, 2025
…e file updates. (#3914) * Updated notice files for system.formats.cbor. * Updated the build to package AWSSDK.Extensions.CborProtocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the build system to package AWSSDK.Extensions.CborProtocol and updates notice files.
Associated CR for build system details and testing: CR-207874117
Motivation and Context
See associated CR.
Testing
See associated CR.
Screenshots (if appropriate)
Types of changes
Checklist
License