Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Mar 16, 2020

Refs: #2894
This will make removal of TravisCI easy without affecting other PRs, when we retry #2894 in future

Checklist
  • non-code related change (markdown/git settings etc)

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-v2-github
  • Commit ID: ca20ec2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr
Copy link
Member Author

trivikr commented Mar 16, 2020

The above build from comment #3152 (comment) was run, when buildspec was added inline.

Verified from logs:

[Container] 2020/03/16 23:15:34 YAML location is /codebuild/readonly/buildspec.yml

Will update CodeBuild job to read buildspec.yml from repo, and re-run

Done to retrigger CodeBuild job which reads buildspec from repo
@codecov-io
Copy link

Codecov Report

Merging #3152 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3152   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files         330      330           
  Lines        9540     9540           
  Branches     1754     1754           
=======================================
  Hits         9255     9255           
  Misses        285      285

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c4d537...48ce4e7. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-v2-github
  • Commit ID: 48ce4e7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr
Copy link
Member Author

trivikr commented Mar 16, 2020

The build in #3152 (comment) was run with buildspec.yml read from repo

Verified from logs:

[Container] 2020/03/16 23:28:42 YAML location is /codebuild/output/src278311646/src/github.com/aws/aws-sdk-js/buildspec.yml

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copied from Team-owned CodeBuild project, making it easier for future CI improvement.

@trivikr trivikr merged commit 0905f8c into aws:master Mar 16, 2020
@trivikr trivikr deleted the add-buildspec-yml branch March 16, 2020 23:37
@lock
Copy link

lock bot commented Mar 27, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants