Skip to content

Request compression trait #4371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 5, 2023
Merged

Request compression trait #4371

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7e19edd
Request compression: non-streaming operations (#4193)
davidh44 Aug 29, 2023
d9aa0de
Merge streaming branch into base branch (#4370)
davidh44 Aug 30, 2023
079242b
Add changelog
davidh44 Aug 30, 2023
0bde610
Remove unused imports
davidh44 Aug 30, 2023
3b2d92d
Update codegen test classes
davidh44 Aug 30, 2023
292b2ef
Remove old changelog
davidh44 Aug 30, 2023
fe18857
Refactor MockAsyncHttpClient
davidh44 Aug 30, 2023
90d70a8
Remove comments
davidh44 Aug 30, 2023
ef938d6
Fix assertion
davidh44 Aug 30, 2023
3fca02b
Address comments
davidh44 Aug 30, 2023
7bb4df6
Address comments
davidh44 Aug 31, 2023
f3a01c0
Address comments
davidh44 Aug 31, 2023
813e31d
Ensure container names are unique
davidh44 Aug 31, 2023
5baa869
Fix Checkstyle line length
davidh44 Aug 31, 2023
36764eb
Ensure container names are unique
davidh44 Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...ore/src/main/java/software/amazon/awssdk/core/client/builder/SdkDefaultClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,7 @@ private SdkClientConfiguration addCompressionConfigGlobalDefaults(SdkClientConfi
if (systemSetting.isPresent()) {
compressionEnabled = !systemSetting.get();
} else {
String profileName = ProfileFileSystemSetting.AWS_PROFILE.getStringValueOrThrow();
Profile profile = profileFileSupplier.get().profile(profileName).orElse(null);
Profile profile = profileFileSupplier.get().profile(configuration.option(PROFILE_NAME)).orElse(null);
if (profile != null) {
Optional<Boolean> profileSetting = profile.booleanProperty(ProfileProperty.DISABLE_REQUEST_COMPRESSION);
if (profileSetting.isPresent()) {
Expand All @@ -317,8 +316,7 @@ private SdkClientConfiguration addCompressionConfigGlobalDefaults(SdkClientConfi
if (systemSetting.isPresent()) {
compressionThreshold = systemSetting.get();
} else {
String profileName = ProfileFileSystemSetting.AWS_PROFILE.getStringValueOrThrow();
Profile profile = profileFileSupplier.get().profile(profileName).orElse(null);
Profile profile = profileFileSupplier.get().profile(configuration.option(PROFILE_NAME)).orElse(null);
if (profile != null) {
Optional<String> profileSetting = profile.property(ProfileProperty.REQUEST_MIN_COMPRESSION_SIZE_BYTES);
if (profileSetting.isPresent()) {
Expand Down
2 changes: 1 addition & 1 deletion ...oftware/amazon/awssdk/services/mediastoredata/TransferEncodingChunkedIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public static void tearDown() throws InterruptedException {
Waiter.run(() -> syncClientWithApache.describeObject(r -> r.path("/foo")))
.untilException(ObjectNotFoundException.class)
.orFailAfter(Duration.ofMinutes(1));
Thread.sleep(500);
Thread.sleep(1000);
mediaStoreClient.deleteContainer(r -> r.containerName(CONTAINER_NAME));
}

Expand Down