Skip to content

Add option ENABLE_SOURCE_MODIFICATION #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

Add option ENABLE_SOURCE_MODIFICATION #2739

merged 1 commit into from
Oct 10, 2025

Conversation

@justsmth
Copy link
Contributor

@justsmth justsmth commented Oct 9, 2025

Issues:

Addresses: aws/aws-lc-rs#909

Description of changes:

Introduce option to enabled modification of a source directory.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner October 9, 2025 20:23
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.94%. Comparing base (4c02092) to head (89ce58e).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2739      +/-   ##
==========================================
- Coverage   78.94%   78.94%   -0.01%     
==========================================
  Files         675      675              
  Lines      115272   115272              
  Branches    16211    16211              
==========================================
- Hits        91004    91002       -2     
- Misses      23479    23482       +3     
+ Partials      789      788       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the enable-source-modification branch from 79371b8 to 89ce58e Compare October 10, 2025 12:26
@justsmth justsmth merged commit 1f7577b into aws:main Oct 10, 2025
367 of 376 checks passed
@justsmth justsmth deleted the enable-source-modification branch October 10, 2025 18:48
@justsmth justsmth mentioned this pull request Oct 13, 2025
Merged
justsmth added a commit that referenced this pull request Oct 13, 2025
@justsmth
Prepare v1.62.0 (#2743)
5a9df21 
### Description of changes: 
Prepare v1.62.0 release

#### What's Changed
* nginx now supports AWS-LC by @samuel40791765 in
#2714
* Fix tests that assume X25519 will be negotiated by @alexw91 in
#2682
* Fixing a bug in ML-DSA poly_uniform function by @dkostic in
#2721
* Migrate integration omnibus by @skmcgrail in
#2715
* Delete util/bot directory by @justsmth in
#2723
* Don't ignore CMAKE_C_FLAGS w/ MSVC by @justsmth in
#2722
* Bump urllib3 from 2.2.3 to 2.5.0 in /tests/ci by @dependabot[bot] in
#2551
* Type fix in mldsa by @manastasova in
#2308
* Centralize password handling tool-openssl by @kingstjo in
#2555
* crypto/pem: replace strncmp with CRYPTO_memcmp to fix -Wstring-compare
error by @R3hankhan123 in #2724
* Implement dgst CLI command by @nhatnghiho in
#2638
* Add ASN.1 decoding for ML-KEM private keys as seeds by @jakemas in
#2707
* Implement genrsa command by @kingstjo in
#2535
* Move udiv and sencond tweak calculations to when needed by @nebeid in
#2726
* Add null check on RSA key checks by @samuel40791765 in
#2727
* Implement workaround for FORTIFY_SOURCE warning with jitterentropy by
@skmcgrail in #2728
* Implement coverity suggestions by @skmcgrail in
#2730
* Add minimal EC CLI tool implementation by @kingstjo in
#2640
* Adding pkeyutl tool to the CLI by @smittals2 in
#2575
* Add CI dimensions for legacy AVX512 flags by @smittals2 in
#2732
* Fix Libwebsockets CI by @smittals2 in
#2737
* Add option ENABLE_SOURCE_MODIFICATION by @justsmth in
#2739
* Simple script to build/run tests by @justsmth in
#2736
* Add build-time option to opt-out of CPU Jitter Entropy by
@torben-hansen in #2733


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
This was referenced Oct 15, 2025
Closed
Merged
github-merge-queue bot pushed a commit to awslabs/mountpoint-s3 that referenced this pull request Oct 16, 2025
@passaro
Update CRT submodules to latest releases (#1659)
6a38361 
Update the CRT submodules to the latest releases.

Changes of note to us:
- Add option ENABLE_SOURCE_MODIFICATION
[#2739](aws/aws-lc#2739)

This change also sets ENABLE_SOURCE_MODIFICATION=OFF when building
`aws-lc`, in order to address #1658.

<details>
  <summary>Full CRT changelog:</summary>

```
Submodule mountpoint-s3-crt-sys/crt/aws-c-cal cdd052bf..3c6d901a:
  > Fix asn.1 parser on big endian (#228)
  > Clean up error handling around unsupported rsa functions (#227)
  > SHA512 support (#223)
Submodule mountpoint-s3-crt-sys/crt/aws-lc 8ca0b29b..5a9df219:
  > Prepare v1.62.0 (#2743)
  > Add build-time option to opt-out of CPU Jitter Entropy (#2733)
  > Simple script to build/run tests (#2736)
  > Add option ENABLE_SOURCE_MODIFICATION (#2739)
  > Fix Libwebsockets CI (#2737)
  > Add CI dimensions for legacy AVX512 flags (#2732)
  > Adding pkeyutl tool to the CLI (#2575)
  > Add minimal EC CLI tool implementation (#2640)
  > Implement coverity suggestions (#2730)
  > Implement workaround for FORTIFY_SOURCE warning with jitterentropy (#2728)
  > Add null check on RSA key checks (#2727)
  > Move udiv and sencond tweak calculations to when needed (#2726)
  > Implement genrsa command (#2535)
  > Add ASN.1 decoding for ML-KEM private keys as seeds (#2707)
  > Implement dgst CLI command (#2638)
  > crypto/pem: replace strncmp with CRYPTO_memcmp to fix -Wstring-compare error (#2724)
  > Centralize password handling tool-openssl (#2555)
  > Type fix in mldsa (#2308)
  > Bump urllib3 from 2.2.3 to 2.5.0 in /tests/ci (#2551)
  > Don't ignore CMAKE_C_FLAGS w/ MSVC (#2722)
  > Delete util/bot directory (#2723)
  > Migrate integration omnibus (#2715)
  > Fixing a bug in ML-DSA poly_uniform function (#2721)
  > Fix tests that assume X25519 will be negotiated (#2682)
  > nginx now supports AWS-LC (#2714)
```
</details>

### Does this change impact existing behavior?

No.

### Does this change need a changelog entry? Does it require a version
change?

No.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and I agree to the terms of
the [Developer Certificate of Origin
(DCO)](https://developercertificate.org/).

---------

Signed-off-by: Alessandro Passaro <[email protected]>
github-merge-queue bot pushed a commit to awslabs/mountpoint-s3 that referenced this pull request Oct 16, 2025
@passaro
Update CRT submodules to latest releases (#1659)
280c7e0 
Update the CRT submodules to the latest releases.

Changes of note to us:
- Add option ENABLE_SOURCE_MODIFICATION
[#2739](aws/aws-lc#2739)

This change also sets ENABLE_SOURCE_MODIFICATION=OFF when building
`aws-lc`, in order to address #1658.

<details>
  <summary>Full CRT changelog:</summary>

```
Submodule mountpoint-s3-crt-sys/crt/aws-c-cal cdd052bf..3c6d901a:
  > Fix asn.1 parser on big endian (#228)
  > Clean up error handling around unsupported rsa functions (#227)
  > SHA512 support (#223)
Submodule mountpoint-s3-crt-sys/crt/aws-lc 8ca0b29b..5a9df219:
  > Prepare v1.62.0 (#2743)
  > Add build-time option to opt-out of CPU Jitter Entropy (#2733)
  > Simple script to build/run tests (#2736)
  > Add option ENABLE_SOURCE_MODIFICATION (#2739)
  > Fix Libwebsockets CI (#2737)
  > Add CI dimensions for legacy AVX512 flags (#2732)
  > Adding pkeyutl tool to the CLI (#2575)
  > Add minimal EC CLI tool implementation (#2640)
  > Implement coverity suggestions (#2730)
  > Implement workaround for FORTIFY_SOURCE warning with jitterentropy (#2728)
  > Add null check on RSA key checks (#2727)
  > Move udiv and sencond tweak calculations to when needed (#2726)
  > Implement genrsa command (#2535)
  > Add ASN.1 decoding for ML-KEM private keys as seeds (#2707)
  > Implement dgst CLI command (#2638)
  > crypto/pem: replace strncmp with CRYPTO_memcmp to fix -Wstring-compare error (#2724)
  > Centralize password handling tool-openssl (#2555)
  > Type fix in mldsa (#2308)
  > Bump urllib3 from 2.2.3 to 2.5.0 in /tests/ci (#2551)
  > Don't ignore CMAKE_C_FLAGS w/ MSVC (#2722)
  > Delete util/bot directory (#2723)
  > Migrate integration omnibus (#2715)
  > Fixing a bug in ML-DSA poly_uniform function (#2721)
  > Fix tests that assume X25519 will be negotiated (#2682)
  > nginx now supports AWS-LC (#2714)
```
</details>

### Does this change impact existing behavior?

No.

### Does this change need a changelog entry? Does it require a version
change?

No.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and I agree to the terms of
the [Developer Certificate of Origin
(DCO)](https://developercertificate.org/).

---------

Signed-off-by: Alessandro Passaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skmcgrail skmcgrail skmcgrail approved these changes

@dkostic dkostic dkostic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justsmth @codecov-commenter @skmcgrail @dkostic