Build broken on macos darwin

[TroyKomodo]

Problem:

Seems to have broken between aws-lc-sys: 0.31.0 -> 0.32.2

Relevant details

AWS-LC for Rust versions or commit: (6b1bce0...)

Root cause:

cargo:warning=In file included from /Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/bazel-out/darwin_arm64-opt/bin/external/+cargo_vendor+cargo_vendor__aws-lc-sys-0.32.2/_bs.cargo_runfiles/+cargo_vendor+cargo_vendor__aws-lc-sys-0.32.2/aws-lc/third_party/jitterentropy/jitterentropy-library/src/jitterentropy-base.c:33:
cargo:warning=In file included from /Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/bazel-out/darwin_arm64-opt/bin/external/+cargo_vendor+cargo_vendor__aws-lc-sys-0.32.2/_bs.cargo_runfiles/+cargo_vendor+cargo_vendor__aws-lc-sys-0.32.2/aws-lc/third_party/jitterentropy/jitterentropy-library/src/jitterentropy-gcd.h:23:
cargo:warning=In file included from /Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/bazel-out/darwin_arm64-opt/bin/external/+cargo_vendor+cargo_vendor__aws-lc-sys-0.32.2/_bs.cargo_runfiles/+cargo_vendor+cargo_vendor__aws-lc-sys-0.32.2/aws-lc/third_party/jitterentropy/jitterentropy-library/src/jitterentropy-internal.h:45:
cargo:warning=In file included from /Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/bazel-out/darwin_arm64-opt/bin/external/+cargo_vendor+cargo_vendor__aws-lc-sys-0.32.2/_bs.cargo_runfiles/+cargo_vendor+cargo_vendor__aws-lc-sys-0.32.2/aws-lc/third_party/jitterentropy/jitterentropy-library/jitterentropy.h:168:
cargo:warning=/Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/bazel-out/darwin_arm64-opt/bin/external/+cargo_vendor+cargo_vendor__aws-lc-sys-0.32.2/_bs.cargo_runfiles/+cargo_vendor+cargo_vendor__aws-lc-sys-0.32.2/aws-lc/third_party/jitterentropy/jitterentropy-library/jitterentropy-base-user.h:90:10: fatal error: 'CoreServices/CoreServices.h' file not found
cargo:warning=   90 | #include <CoreServices/CoreServices.h>
cargo:warning=      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cargo:warning=1 error generated.
exit status: 1

https://scuffle.buildbuddy.io/invocation/ac737971-7ab7-4145-87e3-822466591461

See attached file for a build log

aws-lc-sys.txt

[justsmth]

Hello!

This is an issue when using "zig" or other cross-compilers targeting an "apple" platform. A mitigation for this is being worked on upstream in AWS-LC: aws/aws-lc#2733

The build should succeed using a native build environment. I'll update here once we have a fix available.

[TroyKomodo]

This isn't a cross compiler or zig this is using clang.

[justsmth]

This isn't a cross compiler or zig this is using clang.

Right, but I assume that this is cross-compiling via a "sandbox"?

I see in the logs that CFLAGS is set:

cargo:warning=Environment Variable found 'CFLAGS': '--sysroot=/Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/external/+_repo_rules2+sysroots-macos-universal -isystem /Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/external/+_repo_rules2+clang-macos-aarch64/include/c++/v1 -isystem /Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/external/+_repo_rules2+clang-macos-aarch64/lib/clang/20/include -no-canonical-prefixes --target=aarch64-apple-darwin -fcolor-diagnostics -U_FORTIFY_SOURCE -fstack-protector -fno-omit-frame-pointer -Wno-builtin-macro-redefined -D__DATE__="redacted" -D__TIMESTAMP__="redacted" -D__TIME__="redacted" -g0 -O2 -D_FORTIFY_SOURCE=1 -DNDEBUG -ffunction-sections -fdata-sections --sysroot=/Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/external/+_repo_rules2+sysroots-macos-universal -isystem /Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/external/+_repo_rules2+clang-macos-aarch64/include/c++/v1 -isystem /Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/external/+_repo_rules2+clang-macos-aarch64/lib/clang/20/include -no-canonical-prefixes --target=aarch64-apple-darwin -fcolor-diagnostics -U_FORTIFY_SOURCE -fstack-protector -fno-omit-frame-pointer -Wno-builtin-macro-redefined -D__DATE__="redacted" -D__TIMESTAMP__="redacted" -D__TIME__="redacted" -g0 -O2 -D_FORTIFY_SOURCE=1 -DNDEBUG -ffunction-sections -fdata-sections -fuse-ld=lld -Wno-error -w'

I'm curious whether the CoreServices header files are available on one of the "system" paths provided by the environment:

• --sysroot=/Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/external/+_repo_rules2+sysroots-macos-universal
• -isystem /Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/external/+_repo_rules2+clang-macos-aarch64/include/c++/v1
• -isystem /Users/runner/.bazel/sandbox/darwin-sandbox/4272/execroot/_main/external/+_repo_rules2+clang-macos-aarch64/lib/clang/20/include -no-canonical-prefixes

[TroyKomodo]

It's not cross compiling it's just using a hermetic sysroot to enforce builds are the same regardless of the machine building them. The sysroot was generated from the GitHub macOS actions runners. I can investigate further but if u could point me where those headers usually live on macOS systems I'll make sure I include them in the build.

[justsmth]

I see several files named CoreServices.h on my system, but they're not aligned into a "CoreServices" directory the way I would expect:

/Applications/Xcode.app/Contents/Developer/Platforms/AppleTVOS.platform/Developer/SDKs/AppleTVOS.sdk/System/Library/Frameworks/CoreServices.framework/Headers/CoreServices.h
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks/CoreServices.framework/Headers/CoreServices.h
/Applications/Xcode.app/Contents/Developer/Platforms/WatchOS.platform/Developer/SDKs/WatchOS.sdk/System/Library/Frameworks/CoreServices.framework/Headers/CoreServices.h
/Applications/Xcode.app/Contents/Developer/Platforms/XROS.platform/Developer/SDKs/XROS.sdk/System/Library/Frameworks/CoreServices.framework/Headers/CoreServices.h
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Versions/A/Headers/CoreServices.h

[TroyKomodo]

It seems, i need to use the full sysroot.

https://github.com/ScuffleCloud/toolchains/releases/tag/macos-sysroots-1

I generate a minimal sysroot which excludes a lot of headers / files we dont typically need and a full one. Full one is a lot bigger so i opted to use a minimal one instead.

I noticed the header is in the full sysroot.

troy@troy-server /t/x/MacOSX14.5.sdk> find . -name CoreServices.h                                                                                                                 
./System/Library/Frameworks/CoreServices.framework/Versions/A/Headers/CoreServices.h
troy@troy-server /t/x/MacOSX14.5.sdk> 

I am rerunning the builds using this sysroot will close the issue if successful

[justsmth]

Hello! I'm curious whether using the other SDK was able to resolve this issue?

[TroyKomodo]

Strangely enough bumping the toolchain to include these extra dependencies causes a lot of issues on macos in bazel. Im currently investigating and I think it would be easier to opt out of these extra dependencies if possible.

[justsmth]

Im currently investigating and I think it would be easier to opt out of these extra dependencies if possible.

There is an upstream change in AWS-LC that allows consumers to opt-out of CPU jitter-entropy, which is the code causing the build failure reported above. This option should be available for aws-lc-rs consumers soon.

[justsmth]

Hello! We just release aws-lc-sys v0.32.3. With this release, if you set AWS_LC_SYS_NO_JITTER_ENTROPY=1 in the build environment it should disable the build (and use) of CPU Jitter Entropy. I believe setting this environment variable will resolve the build issue described above.

Thanks for contacting us about this! Please let us know if you have any further issues with our library.