Fix local package installation #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When packaging the dependencies only the first local package would be included in the final bundle. This change adds support for any number of local directory links to be treated as buildable dependencies. Tests were also added for the case of 1 or 2 local directory links specified in the requirements.txt.
sanathkr
approved these changes
Feb 11, 2019
Contributor
sanathkr
left a comment
sanathkr
left a comment
There was a problem hiding this comment.
Awesome! Thanks for doing this. I think some people reported this bug before.
Contributor
|
@thesriram can you review? |
jfuss
pushed a commit
that referenced
this pull request
Mar 7, 2019
* Fix local package installation (#72) When packaging the dependencies only the first local package would be included in the final bundle. This change adds support for any number of local directory links to be treated as buildable dependencies. Tests were also added for the case of 1 or 2 local directory links specified in the requirements.txt. * fix: Remove tests from .whl file (bdist_wheel) (#90) * Add .NET Core builder support (#91) * feat(maven): Support for Java Maven builder (#87) * chore: version bump to 0.2.0 (#94)
jfuss
pushed a commit
to jfuss/aws-lambda-builders
that referenced
this pull request
Mar 15, 2019
* Fix local package installation (aws#72) When packaging the dependencies only the first local package would be included in the final bundle. This change adds support for any number of local directory links to be treated as buildable dependencies. Tests were also added for the case of 1 or 2 local directory links specified in the requirements.txt. * fix: Remove tests from .whl file (bdist_wheel) (aws#90) * Add .NET Core builder support (aws#91) * feat(maven): Support for Java Maven builder (aws#87) * chore: version bump to 0.2.0 (aws#94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When packaging the dependencies only the first local package would be
included in the final bundle. This change adds support for any number
of local directory links to be treated as buildable dependencies. Tests
were also added for the case of 1 or 2 local directory links specified
in the requirements.txt.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.