GoDep Design doc #70
Merged
GoDep Design doc #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfuss
suggested changes
Jan 14, 2019
Contributor
jfuss
left a comment
jfuss
left a comment
There was a problem hiding this comment.
Just a small piece of feedback. Thanks for going back and adding this.
| - `GOOS=linux GOARCH=amd64 go build -o handler main.go` | ||
| - `zip -r source.zip` | ||
|
|
||
| The scope of `sam build` would be to create a macro for these commands to ensure that spelling and paths are correct. |
Contributor
There was a problem hiding this comment.
Can you make this the scope of the aws-lambda-builders? I want to make sure we focus on the this library provides directly so we don't constrain the library to only support SAM CLI.
jfuss
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Creates a design doc for go-dep builder, it was omitted from the original PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.