feat: Make esbuild command builder accept any flag #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbda-builders into esbuild-arbitrary-flags
mndeveci
reviewed
May 8, 2023
Contributor
mndeveci
left a comment
mndeveci
left a comment
There was a problem hiding this comment.
Looks good in general, and very good improvement. Left some comments for some additional logging there.
This reverts commit 20a6636.
…mbda-builders into esbuild-arbitrary-flags
mndeveci
approved these changes
May 16, 2023
lucashuy
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sam-cli#4827
aws/aws-sam-cli#5170
Description of changes:
Instead of having to manually support esbuild flags, determines the type of the flag provided and creates the corresponding command line argument for that flag type.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.