fix: Allow sync to work with dependencies in source #368
+87
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mndeveci
reviewed
Jun 3, 2022
Contributor
mndeveci
left a comment
mndeveci
left a comment
There was a problem hiding this comment.
Looks good in general, left some comments regarding styling.
mndeveci
reviewed
Jun 3, 2022
mndeveci
approved these changes
Jun 4, 2022
Contributor
|
Side note: at the review session we confirmed that the app builder changes were run locally against CLI integration tests and passed. Discussed the necessity to add in an integration test on this, we will assign new task points to design an integration test. |
calavera
pushed a commit
to calavera/aws-lambda-builders
that referenced
this pull request
Jul 10, 2022
* fix: Allow sync to work with dependencies in source * Use Path for assertions * Add type annotations and make class members protected * Test through public method only * Compare paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sam-cli#3707
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.