Skip to content

Conversation

@JimMadge
Copy link
Contributor

@JimMadge JimMadge commented Oct 2, 2019

In xilinx_2019.1 @ 0ec1aef (and not previous versions) the hello world example is located in $SDACCEL_DIR/examples/xilinx/getting_started/hello_world/helloworld_ocl/ rather than $SDACCEL_DIR/examples/xilinx/getting_started/host/helloworld_ocl/

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

In xilinx_2019.1 @ 0ec1aef (and not previous versions) the hello world example is located in $SDACCEL_DIR/examples/xilinx/getting_started/hello_world/helloworld_ocl/ rather than $SDACCEL_DIR/examples/xilinx/getting_started/host/helloworld_ocl/
@deeppat deeppat self-requested a review October 10, 2019 15:32
Copy link
Contributor

@deeppat deeppat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths have changed only for 2019.1 examples.
I think this is good for now, I'll have to add sections for 2017.4, 2018.2 and 2018.3 with the old path, but that can be done in a separate release.

@deeppat deeppat merged commit ba941a1 into aws:master Oct 10, 2019
kyyalama2 pushed a commit that referenced this pull request May 24, 2022
* Remove duplicate line (#468)

* Correct path for helloworld example (#466)

In xilinx_2019.1 @ 0ec1aef (and not previous versions) the hello world example is located in $SDACCEL_DIR/examples/xilinx/getting_started/hello_world/helloworld_ocl/ rather than $SDACCEL_DIR/examples/xilinx/getting_started/host/helloworld_ocl/

* Update path (#470)

* Update path

Attempting to change directories into this path (i.e., `/home/centos/src/project_data/aws-fpga/SDAccel/examples/xilinx_2017.4/getting_started/host/helloworld_ocl`) draws an error because the `xilinx_2017.4` directory is empty, now, and `xilinx` is a symbolic link that points to the latest release (i.e., `/home/centos/src/project_data/aws-fpga/SDAccel/examples/xilinx_2019.1`).  Additionally: `helloworld_ocl` is no longer a sub-directory of `host`; it's now a sub-directory of `hello_world`: so this part of the path should be updated as well.

* Fix unset flags

The alphanumeric part of these flags (i.e., `f`) are preceded by en dashes, when they should be hyphens; as using the former instead of the later results in errors (`-bash: unset: ``–f': not a valid identifier`).

* Update path to workspace directory

This change is consistent with 48c3048, and the basename of the image, but has a different filename extension because of the transparency.

* Update figures 1, 2, and 3 for SDx 2019.1 (#471)

* Update gui_fig_2.png and gui_fig_3.png to SDx 2019.1
SDx's welcome screen has stratified the option (read: clickable button)
to `Create SDx Project` into two new ones: `Create Platform Project`
and `Create Library Project`.  These changes are rendered in Figure 2,
while Figure 3 captures cosmetic differences to the user interface.

* Add Figure 2

* Add Figure 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants