Use public ECR for images that exist there. #422
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that CodeBuild jobs to build these images should always succeed rather than hitting rate limits at Docker.
|
Sounds good! |
leoherran-aws
approved these changes
Jul 23, 2021
|
Merged in b1a5c66. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds the AWS public ECR to the image sources (for image tags that are actually hosted there).
This should make builds of these images, and specifically, builds of these images in CodeBuild pipelines, succeed more reliably.
This MR prompted by my pipeline that builds the CodeBuild images (because the CodeBuild images are not in the ECR Public repo) failing out b/c of Docker rate limits.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.