feat(cfn-include): add support for the Fn::Sub function #9275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Adam Ruka <[email protected]>
…::And, Fn::Not, and Fn::Or, including unit tests.
…ntrinsic functions
…ied the return type of transform to IResolvable, and updated transform docs
skinny85
changed the title
skinny85
previously requested changes
Jul 28, 2020
Contributor
skinny85
left a comment
skinny85
left a comment
There was a problem hiding this comment.
Generally looks great! I'd like to see some small cleanup of the code, and a few more tests before I'm comfortable giving my "ShipIt".
packages/@aws-cdk/cloudformation-include/test/test-templates/fn-sub-shadow.json
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/yaml-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/yaml-templates.test.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
curtiseppel
pushed a commit
to curtiseppel/aws-cdk
that referenced
this pull request
Aug 11, 2020
---- Closes aws#9228 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9228
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license