Skip to content

Conversation

@vishaalmehrishi
Copy link
Contributor

@vishaalmehrishi vishaalmehrishi commented Sep 25, 2025

Issue

Closes #35199.

Reason for this change

Adding support for DocumentDB serverless clusters

Description of changes

Added the new ServerlessV2ScalingConfiguration property which maps to the corresponding CFN property.

instanceType is no longer a required field, since a serverless cluster has no instance type. This is not a breaking change since loosening constraints does not impact existing users.

The choice of instanceType or serverlessV2ScalingConfiguration aligns with the AWS console experience of choosing between the two when creating a cluster.

Screenshot 2025-09-25 at 14 20 27 Screenshot 2025-09-25 at 14 20 34

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 25, 2025 12:00
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Sep 25, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 25, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 25, 2025 12:18

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@alvazjor alvazjor self-assigned this Sep 26, 2025
@mergify mergify bot added the queued label Sep 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot removed the queued label Sep 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #35574 has been manually updated.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

Copy link
Contributor

@alvazjor alvazjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing previous approval

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this folder correct? snapshots are generated for the js files not the ts ones, so I think got included by mistake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks! I've removed the folder in the next commit

@mergify mergify bot added the queued label Sep 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot added a commit that referenced this pull request Sep 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot added a commit that referenced this pull request Sep 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35574 has been dequeued. Mergify failed to merge the pull request. GitHub can't merge the pull request after 15 retries.
Waiting for the branch protection required status checks to be validated.

You can check the last failing draft PR here: #35596.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Sep 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Sep 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot added a commit that referenced this pull request Sep 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot added a commit that referenced this pull request Sep 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #35574 has been manually updated.

You can check the last failing draft PR here: #35600.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Sep 26, 2025
@alvazjor
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

refresh

✅ Pull request refreshed

@mergify mergify bot added the queued label Sep 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot added a commit that referenced this pull request Sep 26, 2025
@mergify mergify bot merged commit 89bfef7 into main Sep 26, 2025
31 checks passed
@mergify mergify bot deleted the mehrishi/docdb-serverless branch September 26, 2025 17:11
@mergify mergify bot removed the queued label Sep 26, 2025
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-docdb: support Serverless Cluster

4 participants