Skip to content

Conversation

@alvazjor
Copy link
Contributor

Issue # (if applicable)

Closes #34168

Reason for this change

SecretRotationApplication was using semantic version 1.1.367 which creates a secret rotation lambda using python version 3.9 which is EOL

Description of changes

Updated semantic version to 1.1.618, that will upgrade the python version of the SecretRotationApplication to version 3.10

Describe any new or updated permissions being added

NA

Description of how you validated changes

Integration tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Updates all SecretRotationApplication versions from 1.1.367 to 1.1.618
to use Python 3.10 instead of deprecated Python 3.9 runtime.
@github-actions github-actions bot added feature-request A feature should be added or improved. p1 labels Sep 19, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team September 19, 2025 12:17
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 19, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@alvazjor alvazjor changed the title fix(secretsmanager): SecretRotationApplication creates lambda on python 3.9 which is EOL fix(secretsmanager): SecretRotationApplication creates lambda on python 3.9 which is EOL Sep 19, 2025
@alvazjor alvazjor added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Sep 19, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 19, 2025 12:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@alvazjor
Copy link
Contributor Author

Added the pr-linter/exempt-integ-test label as they were complaining about missing integ tests, but this change include modified integ tests...

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 756b683 into main Sep 19, 2025
47 checks passed
@mergify mergify bot deleted the fix/secrets-rotation-python39-eol branch September 19, 2025 12:45
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. feature-request A feature should be added or improved. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws secrets manager): addRotationSingleUser() creates a lambda on python 3.9 which is announced for deprecation

3 participants