-
Couldn't load subscription status.
- Fork 4.3k
feat(stepfunctions-tasks): add Node.js 22 support to EvaluateExpression #35370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds support for Runtime.NODEJS_22_X in the EvaluateExpression construct. Fixes aws#35353
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @claypack
Thanks for the contribution. We have some integ tests for the EvaluateExpression resource: packages/@aws-cdk-testing/framework-integ/test/aws-stepfunctions-tasks/test/integ.evaluate-expression-default-runtime.ts
Can you create a similar one using the new NodeVersion you are adding, please? Thanks
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #35353.
Reason for this change
Currently you are unable to specify the NodeJS 22 Runtime directly in the EvaluateExpression construct. When users try to use
Runtime.NODEJS_22_X, they receive an error that this runtime is not supported.Description of changes
nodeJsGuidsobject inevaluate-expression.tswith UUID'b64e1fb8-9c89-4f7d-8a34-2e2a1c5f6d7e'evaluate-expression.test.tsThe changes follow the exact same pattern as existing Node.js runtime support (Node.js 20, 18, etc.). No alternatives were considered as this is a straightforward addition to the existing runtime mapping system. The UUID was generated to ensure uniqueness for the singleton Lambda function pattern used by EvaluateExpression.
Describe any new or updated permissions being added
No new or updated IAM permissions are required. This change only adds support for an additional Lambda runtime version.
Description of how you validated changes
nodejs22.xruntimeChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license