Skip to content

Conversation

@claypack
Copy link
Contributor

Issue # (if applicable)

Closes #35353.

Reason for this change

Currently you are unable to specify the NodeJS 22 Runtime directly in the EvaluateExpression construct. When users try to use Runtime.NODEJS_22_X, they receive an error that this runtime is not supported.

Description of changes

  • Added Node.js 22 runtime mapping to the nodeJsGuids object in evaluate-expression.ts with UUID 'b64e1fb8-9c89-4f7d-8a34-2e2a1c5f6d7e'
  • Added unit test coverage for Node.js 22 runtime in evaluate-expression.test.ts

The changes follow the exact same pattern as existing Node.js runtime support (Node.js 20, 18, etc.). No alternatives were considered as this is a straightforward addition to the existing runtime mapping system. The UUID was generated to ensure uniqueness for the singleton Lambda function pattern used by EvaluateExpression.

Describe any new or updated permissions being added

No new or updated IAM permissions are required. This change only adds support for an additional Lambda runtime version.

Description of how you validated changes

  • Added unit test that verifies EvaluateExpression creates a Lambda function with nodejs22.x runtime
  • All existing tests continue to pass (5/5 tests passing)
  • Manually tested by creating a CDK app, synthesizing CloudFormation template, and deploying to AWS
  • Verified the deployed Lambda function uses Node.js 22 runtime and executes successfully and returns

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Adds support for Runtime.NODEJS_22_X in the EvaluateExpression construct.

Fixes aws#35353
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Aug 30, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team August 30, 2025 04:50
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@alvazjor alvazjor self-assigned this Sep 1, 2025
@alvazjor alvazjor added the pr-linter/exempt-readme The PR linter will not require README changes label Sep 1, 2025
Copy link
Contributor

@alvazjor alvazjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @claypack
Thanks for the contribution. We have some integ tests for the EvaluateExpression resource: packages/@aws-cdk-testing/framework-integ/test/aws-stepfunctions-tasks/test/integ.evaluate-expression-default-runtime.ts
Can you create a similar one using the new NodeVersion you are adding, please? Thanks

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 1, 2025 16:03

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@claypack claypack requested a review from alvazjor September 2, 2025 02:14
@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 640821d into aws:main Sep 2, 2025
18 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-stepfunctions-tasks: EvaluateExpression Support for NodeJS 22

3 participants