Skip to content

Conversation

@badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Aug 29, 2025

Issue # (if applicable)

None

Reason for this change

deviceCertificateAgeCheckDuration has a upper bound value (3652 days) but we cannot deploy AccountAuditConfiguration construct when this duration is set 3651-3652 days.

10:51:08 PM | UPDATE_FAILED        | AWS::IoT::AccountAuditConfiguration | AuditConfiguration8C793652
Resource handler returned message: "Certificate age threshold is greater than the maximum supported threshold of 3650 days. (Service: Iot, Status Code: 400, Request ID: 20cddf20-
f5a5-4f4b-8fee-140be1305778) (SDK Attempt Count: 1)" (RequestToken: 931fdbeb-f895-c970-b0a5-5e7a2f9a86be, HandlerErrorCode: InvalidRequest)

AWS docs states that upper bound value is 3652 days but I think this statement is wrong.

Description of changes

  • set update upper bound value to 3650 days from 3652 days

Describe any new or updated permissions being added

None

Description of how you validated changes

update unit test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 29, 2025 16:07
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Aug 29, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@badmintoncryer badmintoncryer changed the title fix:() fix(iot): cannot set a value greater than 3650 days for deviceCertificateAgeCheckDuration Aug 29, 2025
@badmintoncryer badmintoncryer changed the title fix(iot): cannot set a value greater than 3650 days for deviceCertificateAgeCheckDuration chore(iot): cannot set a value greater than 3650 days for deviceCertificateAgeCheckDuration Aug 29, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 29, 2025 16:19

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@alvazjor alvazjor self-assigned this Sep 1, 2025
alvazjor
alvazjor previously approved these changes Sep 1, 2025
@mergify mergify bot dismissed alvazjor’s stale review September 2, 2025 09:53

Pull request has been modified.

alvazjor
alvazjor previously approved these changes Sep 2, 2025
@mergify mergify bot dismissed alvazjor’s stale review September 2, 2025 11:33

Pull request has been modified.

alvazjor
alvazjor previously approved these changes Sep 2, 2025
@mergify mergify bot dismissed alvazjor’s stale review September 2, 2025 11:58

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6d64bda into aws:main Sep 2, 2025
18 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2025
@badmintoncryer badmintoncryer deleted the iot-validation branch September 24, 2025 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants