Skip to content

Conversation

@abidhasan-aws
Copy link
Contributor

@abidhasan-aws abidhasan-aws commented Aug 27, 2025

Reason for this change

  • Current custom resource handlers are using Python 3.9 and 3.11 runtimes
  • Python 3.9 reaches EOL in October 2025
  • Need to upgrade to Python 3.13 for better stability and continued support
  • Affects multiple custom resource handlers including aws-ecs/drain-hook-provider, aws-eks/kubectl-provider, and others

Description of changes

  • Updated Python runtime from 3.9/3.11 to 3.13 in config.ts for generated bundle functions
  • Modified runtime settings in:
    • notifications-resource-handler.ts
    • instance-drain-hook.ts
  • Updated aws-eks-v2-alpha custom resource handler runtime
  • Updated integration tests and snapshots

Validation

  • Deployed integration tests across multiple regions to verify functionality
  • Verified Lambda Python 3.13 availability across required regions

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 27, 2025 17:41
@github-actions github-actions bot added the p2 label Aug 27, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 27, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@abidhasan-aws abidhasan-aws changed the title Upgrade to python runtime 313 chore: Upgrade to python runtime 3.13 for custom resources Aug 28, 2025
@abidhasan-aws abidhasan-aws marked this pull request as ready for review August 29, 2025 15:17
@abidhasan-aws abidhasan-aws changed the title chore: Upgrade to python runtime 3.13 for custom resources feat: Upgrade to python runtime 3.13 for custom resources Sep 2, 2025
@aemada-aws
Copy link
Contributor

title should be feat(custom-resource)

@abidhasan-aws abidhasan-aws changed the title feat: Upgrade to python runtime 3.13 for custom resources feat(custom-resource): Upgrade to python runtime 3.13 for custom resources Sep 3, 2025
@abidhasan-aws abidhasan-aws added the pr-linter/exempt-readme The PR linter will not require README changes label Sep 3, 2025
@abidhasan-aws abidhasan-aws requested review from aws-cdk-automation and removed request for a team September 3, 2025 13:59
@abidhasan-aws abidhasan-aws added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Sep 3, 2025
@abidhasan-aws abidhasan-aws changed the title feat(custom-resource): Upgrade to python runtime 3.13 for custom resources feat(custom-resource): upgrade to python runtime 3.13 for custom resources Sep 3, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 3, 2025 14:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #35342 has been manually updated.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3db140e into main Sep 3, 2025
18 of 19 checks passed
@mergify mergify bot deleted the upgrade-to-python-runtime-313 branch September 3, 2025 16:33
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants