docs: add a note to prevent additional feature changes to OpenIdConnectProvider
#35310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
effort/small
ozelalisen
approved these changes
Aug 25, 2025
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20460.
Reason for this change
OpenIdConnectProvider, which usesCustomResource, is on the path to deprecation. It is still used in EKS, but is superseded byOIDCProviderNative, which provides the same functionality by using the native CloudFormation resource, with less infrastructure complexity.See #28634 (comment) for why it cannot be deprecated.
Description of changes
Added a big comment block explaining why we should not support non-critical changes to
OpenIdConnectProviderDescribe any new or updated permissions being added
None.
Description of how you validated changes
No validations, added comments only.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license