-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(cloudfront): add validation for configuring response headers policy #35308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
None
Reason for this change
When creating a
ResponseHeadersPolicy, if we setaccessControlAllowCredentialsto true in the CORS configuration and include a string containing*inaccessControlAllowHeaders, it causes a deployment error. I added validation to prevent this in advance.Description of changes
Add validation for
ResponseHeadersPolicy.Describe any new or updated permissions being added
None
Description of how you validated changes
Add unit test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license