Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
308fe07
feat(custom-resources): add External ID support for AwsCustomResource
oyiz-michael Aug 17, 2025
58a2fcd
fix: simplify external ID integration test
oyiz-michael Aug 17, 2025
ed5414d
feat(custom-resources): add integration test snapshots for External I…
oyiz-michael Aug 17, 2025
38bf24a
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Aug 31, 2025
2ceb485
Update packages/aws-cdk-lib/custom-resources/lib/aws-custom-resource/…
oyiz-michael Sep 1, 2025
2814c27
Update packages/aws-cdk-lib/custom-resources/README.md
oyiz-michael Sep 1, 2025
e7b0b14
Update packages/aws-cdk-lib/custom-resources/README.md
oyiz-michael Sep 1, 2025
726b01d
fix: simplify ExternalId parameter handling as per review feedback
oyiz-michael Sep 1, 2025
f40d68e
fix: add validation for ExternalId without assumedRoleArn
oyiz-michael Sep 1, 2025
3d80e2f
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Sep 1, 2025
12382c7
fix: restore missing externalId property declaration
oyiz-michael Sep 3, 2025
d98ffd4
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Sep 3, 2025
eb9e438
fix: correct variable name in README example
oyiz-michael Sep 3, 2025
0402179
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Sep 3, 2025
5a61d89
fix: replace CloudFormation intrinsics with hardcoded test ARNs in in…
oyiz-michael Sep 4, 2025
e5ecb3f
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Sep 4, 2025
e4baefe
fix: resolve unused variable ESLint error in utils.ts
oyiz-michael Sep 4, 2025
b4325cf
fix: resolve test failures and ESLint errors for External ID feature
oyiz-michael Sep 6, 2025
db05ddc
chore: fix ESLint errors in aws-cdk-lib
oyiz-michael Sep 6, 2025
9b069db
fix: resolve security scanner violation in External ID integration test
oyiz-michael Sep 6, 2025
14adde3
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Sep 6, 2025
0fc3fb8
Merge branch 'aws:main' into feature/custom-resource-external-id-support
oyiz-michael Sep 8, 2025
081f47b
fix(custom-resources): fix external ID tests for AwsCustomResource
oyiz-michael Sep 9, 2025
8ed1399
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Sep 9, 2025
6c0c9b3
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Sep 9, 2025
9eef603
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Sep 11, 2025
6e0169e
fix(custom-resources): fix external ID test assertions and missing sn…
oyiz-michael Sep 13, 2025
4180439
feat: rebuild comprehensive external ID test suite for AwsCustomResource
oyiz-michael Sep 13, 2025
412d1f7
feat(custom-resources): generate missing External ID integration test…
oyiz-michael Sep 15, 2025
7052fcd
fix(custom-resources): correct External ID integration test naming to…
oyiz-michael Sep 15, 2025
27ce0f7
fix(integ-test): stabilize External ID integration test to prevent de…
oyiz-michael Sep 15, 2025
65b0fa9
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Sep 15, 2025
1597c13
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Sep 17, 2025
dd5fa93
fix: address code review feedback
oyiz-michael Sep 24, 2025
5c75f07
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Sep 24, 2025
17b99cf
test: replace weak JSON.stringify assertions with proper CDK Template…
oyiz-michael Oct 7, 2025
2d5ce8d
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Oct 7, 2025
beda0da
fix: move ExternalId validation to construct constructor
oyiz-michael Oct 8, 2025
aadad69
test: improve externalId assertions to verify correct JSON field
oyiz-michael Oct 8, 2025
a7730c1
fix(custom-resources): validate externalId requires assumedRoleArn
oyiz-michael Oct 11, 2025
6f88234
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Oct 11, 2025
ad948a3
fix(integ): fix lint errors in external-id integration test
oyiz-michael Oct 12, 2025
b3687df
fix(integ): allow CDKMetadata destruction in external-id test
oyiz-michael Oct 13, 2025
7a26411
fix(integ): allow CDKMetadata destruction and use dynamic account in …
oyiz-michael Oct 13, 2025
4343aaa
chore: update integration test snapshots for AwsCustomResource changes
Oct 18, 2025
130382c
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Oct 18, 2025
3df08ea
test(custom-resources): update snapshots after main merge
Oct 19, 2025
dcda62e
additonal missing snapshots
Oct 20, 2025
e1ce4df
Merge branch 'main' into feature/custom-resource-external-id-support
oyiz-michael Oct 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -827,7 +827,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "a73ebb32184d4a847fd87c0def742ac63ae3716c77d7d75f37ffe720d056adc6.zip"
"S3Key": "89f8c437feaf078124252df938abc83ca969185d1730374a4ab70530e6b34616.zip"
},
"Handler": "index.handler",
"Role": {
Expand Down

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "a73ebb32184d4a847fd87c0def742ac63ae3716c77d7d75f37ffe720d056adc6.zip"
"S3Key": "89f8c437feaf078124252df938abc83ca969185d1730374a4ab70530e6b34616.zip"
},
"Handler": "index.handler",
"Role": {
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "a73ebb32184d4a847fd87c0def742ac63ae3716c77d7d75f37ffe720d056adc6.zip"
"S3Key": "89f8c437feaf078124252df938abc83ca969185d1730374a4ab70530e6b34616.zip"
},
"Handler": "index.handler",
"Role": {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading